Skip to content

Commit 31ca913

Browse files
committed
Fix check of versions to allow pre-release
1 parent 58062e4 commit 31ca913

File tree

4 files changed

+19
-16
lines changed

4 files changed

+19
-16
lines changed

lib/get-latest-patch-versions.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
import { groupBy } from 'lodash-es';
2-
import semverCompare from 'semver-compare';
3-
import semverUtils from 'semver-utils';
2+
import semver from 'semver';
43

54
export function getLatestPatchVersions(versions) {
65
let groupedVersions = groupBy(
7-
versions.sort(semverCompare).map(semverUtils.parse),
8-
v => `${v.major}.${v.minor}`,
6+
versions.sort((a, b) => semver.rcompare(a, b)),
7+
v => `${semver.major(v)}.${semver.minor(v)}`,
98
);
10-
return Object.values(groupedVersions).map(verGroup => verGroup.pop().version);
9+
return Object.values(groupedVersions).map(verGroup => verGroup[0]);
1110
}

lib/normalize-ids.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ function extractRelationship({ id, type }) {
1313
return { id, type };
1414
}
1515

16-
function filterForVersion(version) {
16+
function filterForVersion(project, version) {
1717
return ({ relationships }) => {
18-
const projectVersion = relationships['project-version'].data.id.split('-').pop();
18+
const projectVersion = relationships['project-version'].data.id.replace(`${project}-`, '');
1919
return version.version === projectVersion;
2020
};
2121
}
@@ -56,7 +56,7 @@ async function normalizeIDs(pVersions, projectName) {
5656

5757
let projectVersions = pVersions.map(version => {
5858
let classes = findType(jsonapidoc, 'class')
59-
.filter(filterForVersion(version))
59+
.filter(filterForVersion(projectName, version))
6060
.filter(removeLongDocsBecauseEmber1HasWeirdDocs);
6161

6262
let namespaces = classes.filter(({ attributes }) => attributes.static === 1);
@@ -67,7 +67,7 @@ async function normalizeIDs(pVersions, projectName) {
6767
namespaces.forEach(ns => (ns.type = 'namespace'));
6868

6969
let modules = findType(jsonapidoc, 'module')
70-
.filter(filterForVersion(version))
70+
.filter(filterForVersion(projectName, version))
7171
.filter(curry(filter176)(projectName, version.version));
7272

7373
return {

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@
6464
"eslint-plugin-prettier": "^5.0.1",
6565
"mocha": "^10.2.0",
6666
"prettier": "^3.0.3",
67-
"pretty-quick": "^1.11.1"
67+
"pretty-quick": "^1.11.1",
68+
"semver": "^7.7.2"
6869
},
6970
"packageManager": "[email protected]+sha512.76e2379760a4328ec4415815bcd6628dee727af3779aaa4c914e3944156c4299921a89f976381ee107d41f12cfa4b66681ca9c718f0668fa0831ed4c6d8ba56c"
7071
}

pnpm-lock.yaml

Lines changed: 9 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)