Convert the RFCs app to be a proper app that helps uses #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data loading
✅ Deploy Preview for ember-rfcs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MinThaMie
commented
Sep 15, 2025
app/templates/index.gjs
Outdated
| <h2>These RFCs are in their Final Comment Period and will move to their next stage in {{daysUntilFriday}} days</h2> | ||
| <div> | ||
| {{#each @model as |rfc|}} | ||
| <LinkTo class="fcp-item" @route="rfc" @model={{rfc.rfcFile}}>#{{rfc.number}} {{rfc.title}}</LinkTo> |
There was a problem hiding this comment.
@mansona for some weird reason the RFC provided by the toc-fcp-builder doesn't have the rfcFile property. Could you check why?
mansona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.