added a target to build a static library + bugfix: don't try copying more than available in the input buffer #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renamed the shared object using the standard 'lib' prefix added a main Makefile to allow building/installing the library from the top directory
sip_hash_final() will take care of padding the buffer (to be multiple of uint64_t) if necessary
int_sip_pre_update() was not working properly if the provided data + the previous buffer didn't still reach the size of a full uint64_t
…_pre_update() since the function may advance the pointer while fetching the bytes missing to reach a complete uint64_t (by adding the accumulated bytes from previous calls)
some potential leaks on error paths and some other minor thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed the shared object using the standard 'lib' prefix
added a main Makefile to allow building/installing the library from the top directory
bugfix: don't try copying more than available in the input buffer … (MAJOR!!)
sip_hash_final() will take care of padding the buffer (to be multiple of uint64_t) if necessary (MAJOR!!)
bugfix in the streaming-api implementation (was not working in most cases) (MAJOR!!)
one more bugfix: the data64 pointer MUST be set after calling int_sip_pre_update() (MAJOR!!)