Skip to content

Commit 3911aaf

Browse files
committed
chore: simplify creating game players (thx @mudkipdev)
1 parent 805d9aa commit 3911aaf

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

src/main/java/dev/emortal/minestom/gamesdk/internal/GameTracker.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import dev.emortal.minestom.gamesdk.game.Game;
1717
import dev.emortal.minestom.gamesdk.game.GameUpdateRequestEvent;
1818
import dev.emortal.minestom.gamesdk.internal.listener.GameStatusListener;
19+
import dev.emortal.minestom.gamesdk.util.BasicGamePlayerConverter;
1920
import net.minestom.server.entity.Player;
2021
import net.minestom.server.event.Event;
2122
import net.minestom.server.event.EventNode;
@@ -159,15 +160,8 @@ private void updateGame(@NotNull Game game) {
159160
}
160161

161162
private @NotNull List<BasicGamePlayer> createGamePlayers(@NotNull Game game) {
162-
List<BasicGamePlayer> gamePlayers = new ArrayList<>();
163-
164-
for (Player player : game.getPlayers()) {
165-
gamePlayers.add(BasicGamePlayer.newBuilder()
166-
.setId(player.getUuid().toString())
167-
.setUsername(player.getUsername())
168-
.build());
169-
}
170-
171-
return gamePlayers;
163+
return game.getPlayers().stream()
164+
.map(BasicGamePlayerConverter::fromMinestomPlayer)
165+
.toList();
172166
}
173167
}

0 commit comments

Comments
 (0)