Skip to content

Commit 304d7d5

Browse files
committed
clean: Remove GRPC_JAVA_VERSION_BUILD
See grpc/grpc-java#12135, re. grpc/grpc-java#12055.
1 parent 841d081 commit 304d7d5

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

MODULE.bazel

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,12 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
# Nota bene, any shared version numbers defined here should ONLY be
18-
# for Maven versions (of multiple artifacts), and NOT also used in bazel_dep()
19-
# mod versions; because bazel-steward may update the variable but
20-
# not the bazel_dep, or vice versa, leading to inconsistencies (see
21-
# https://github.com/VirtusLab/bazel-steward/issues/404).
22-
2317
ADK_JAVA_COMMIT = "99265cf268be4dbd0a82decf5c48bf57b3725b53"
2418

2519
RDF4J_VERSION = "5.1.4"
2620

2721
GRPC_JAVA_VERSION = "1.75.0"
2822

29-
# Separate because of https://github.com/VirtusLab/bazel-steward/issues/404:
30-
GRPC_JAVA_VERSION_BUILD = "1.73.0"
31-
3223
# see ./tools/java_toolchain/BUILD
3324
# see https://github.com/bazelbuild/bazel/issues/20877, NB the "_definition" suffix!
3425
register_toolchains("//tools/java_toolchain:repository_default_java_toolchain_definition")
@@ -51,9 +42,10 @@ switched_rules.use_languages(java = True)
5142
# https://registry.bazel.build/modules/grpc-java
5243
# TODO How to avoid the ugly WARNING & DEBUG once https://github.com/grpc/grpc-java/issues/11792
5344
# and https://github.com/grpc/grpc-java/issues/11791 are fixed (and released).
54-
bazel_dep(name = "grpc-java", version = GRPC_JAVA_VERSION_BUILD, repo_name = "io_grpc_grpc_java")
45+
bazel_dep(name = "grpc-java", version = GRPC_JAVA_VERSION, repo_name = "io_grpc_grpc_java")
5546

5647
# https://github.com/grpc/grpc-java/issues/12055
48+
# https://github.com/grpc/grpc-java/pull/12135
5749
git_override(
5850
module_name = "grpc-java",
5951
remote = "https://github.com/grpc/grpc-java.git",

0 commit comments

Comments
 (0)