bssl-compat on bazel 1.35#417
Closed
tedjpoole wants to merge 1 commit intoenvoyproxy:release/v1.35from
Closed
Conversation
jwendell
reviewed
Nov 6, 2025
tedjpoole
force-pushed
the
bssl-compat-bazel-1.35
branch
6 times, most recently
from
51e17c7 to
ded0fb4
Compare
jwendell
reviewed
Nov 17, 2025
Member
jwendell
left a comment
jwendell
left a comment
There was a problem hiding this comment.
Thanks Ted. It LGTM.
But I'm in favor we land this (and the upcoming change you're working) on 1.36 - or even main if it gets ready soon enough.
Let's try to keep 1.35 "stable".
What do you think?
Contributor
Author
|
That's fine to not merge this, to keep 1.35 stable. |
tedjpoole
force-pushed
the
bssl-compat-bazel-1.35
branch
3 times, most recently
from
0630ea2 to
861053b
Compare
- Uses the @boringssl repo instead of a vendored copy - Added @bssl-compat//test:utests-bssl-compat test target - Added @bssl-compat//test:utests-boringssl test target - Added BoringSSL patch for s390x & ppc64le Signed-off-by: Ted Poole <tpoole@redhat.com> Co-authored-by: Zuzana Miklankova <zmiklank@redhat.com>
tedjpoole
force-pushed
the
bssl-compat-bazel-1.35
branch
from
861053b to
6a19b22
Compare
Contributor
Author
|
Closed this as the work is now being done on the main branch instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With heavy inspiration from #345
Still need to get
utests-bssl-compat&utests-boringbuilding & running.