Skip to content

Conversation

@jukie
Copy link
Contributor

@jukie jukie commented Jul 8, 2025

What type of PR is this?

feat: Implement ZoneAware Lb Config

What this PR does / why we need it:
Implementation for LoadBalancer.ZoneAware API (Ref: #6154)

This adds the internal logic to support explicit configuration for Envoy LocalityLbConfig. Leaving the API marked as hidden/not-implemented because this will depend on a followup for tracking the EnvoyProxy Endpoints in xDS but splitting those changes out since it's a fairly large change (See #6482).

This also replaces DestinationSetting.ZoneAwareRouting with DestinationSetting.PreferLocal to consolidate under the new API field.

Which issue(s) this PR fixes:

xRef #6025

Release Notes: No
(will add release note for whichever PR gets merged last)

@jukie jukie requested a review from a team as a code owner July 8, 2025 16:38
@jukie
Copy link
Contributor Author

jukie commented Jul 8, 2025

CC @rudrakhp @arkodg as you reviewed the API PR

@jukie jukie force-pushed the split-impl-zone-aware-routing branch from 7340dfc to 4e7f0c9 Compare July 8, 2025 16:46
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

❌ Patch coverage is 89.04110% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.00%. Comparing base (2504990) to head (daf2223).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/route.go 72.22% 5 Missing ⚠️
internal/xds/translator/cluster.go 91.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6485   +/-   ##
=======================================
  Coverage   71.00%   71.00%           
=======================================
  Files         225      225           
  Lines       38950    38984   +34     
=======================================
+ Hits        27657    27682   +25     
- Misses       9691     9699    +8     
- Partials     1602     1603    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie
Copy link
Contributor Author

jukie commented Jul 8, 2025

/retest

1 similar comment
@jukie
Copy link
Contributor Author

jukie commented Jul 8, 2025

/retest

@jukie jukie changed the title feat: Implement ZoneAware Lb Config (Phase 1) feat: Implement ZoneAware loadbalancing - ZoneAware Lb Config (splitup #6482) Jul 10, 2025
@jukie
Copy link
Contributor Author

jukie commented Jul 10, 2025

/retest

@jukie
Copy link
Contributor Author

jukie commented Jul 12, 2025

/retest

@arkodg arkodg modified the milestone: v1.5.0-rc.1 Release Jul 16, 2025
@jukie jukie added this to the v1.5.0-rc.1 Release milestone Jul 22, 2025
@jukie
Copy link
Contributor Author

jukie commented Jul 23, 2025

/retest

@jukie jukie requested a review from arkodg July 24, 2025 15:36
@jukie jukie requested a review from arkodg July 24, 2025 17:51
@jukie
Copy link
Contributor Author

jukie commented Jul 24, 2025

/retest

@arkodg arkodg requested review from a team July 24, 2025 21:13
@jukie
Copy link
Contributor Author

jukie commented Jul 25, 2025

/retest

@arkodg arkodg merged commit a78ff3e into envoyproxy:main Jul 25, 2025
39 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants