-
Notifications
You must be signed in to change notification settings - Fork 583
setup allowRequestsWithoutProxyProtocol #6545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup allowRequestsWithoutProxyProtocol #6545
Conversation
Signed-off-by: Ryan Hristovski <[email protected]>
| // If not set, the default behavior is to reject requests without a Proxy Protocol header. | ||
| // | ||
| // +optional | ||
| AllowRequestsWithoutProxyProtocol *bool `json:"allowRequestsWithoutProxyProtocol,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer Optional bool similar to what we have in the JWT config
wdyt @envoyproxy/gateway-maintainers @envoyproxy/gateway-reviewers
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6545 +/- ##
==========================================
- Coverage 70.86% 70.80% -0.06%
==========================================
Files 224 224
Lines 38769 38783 +14
==========================================
- Hits 27472 27459 -13
- Misses 9708 9728 +20
- Partials 1589 1596 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // Note Proxy Protocol must be present when this field is set, else the connection | ||
| // is closed. | ||
| // | ||
| // Deprecated: Use ProxyProtocol.Enabled instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no Enabled field
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
|
@arkodg this PR is ready for review |
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
|
/retest |
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Signed-off-by: Ryan Hristovski <[email protected]>
We support downstream proxy protocol #1328 but we don't currently support allow_requests_without_proxy_protocol .
This cannot be applied to upstream (afaik) so it's only being applied to downstream on ctp.
API Proposed:
Hoping to get this in for 1.5, please let me know if you'd like to see anything else