Reduce O(n2) compexity to O(n)

exacs · exacs · commit b1179d8a0b13 · 2025-11-19T15:50:56.000+01:00
diff --git a/packages/optimizely-cms-sdk/src/graph/index.ts b/packages/optimizely-cms-sdk/src/graph/index.ts
@@ -386,9 +386,10 @@ export class GraphClient {
     }
 
     // Return sorted by the "sortedKeys"
+    const linkMap = new Map(links.map((link) => [link._metadata?.key, link]));
     return sortedKeys
-      .map((key) => links.find((link) => link._metadata?.key === key))
-      .filter((item) => typeof item !== 'undefined');
+      .map((key) => linkMap.get(key))
+      .filter((item) => item !== undefined);
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -386,9 +386,10 @@ export class GraphClient {`
`386`	`386`	`}`
`387`	`387`
`388`	`388`	`// Return sorted by the "sortedKeys"`
	`389`	`+ const linkMap = new Map(links.map((link) => [link._metadata?.key, link]));`
`389`	`390`	`return sortedKeys`
`390`		`- .map((key) => links.find((link) => link._metadata?.key === key))`
`391`		`- .filter((item) => typeof item !== 'undefined');`
	`391`	`+ .map((key) => linkMap.get(key))`
	`392`	`+ .filter((item) => item !== undefined);`
`392`	`393`	`}`
`393`	`394`
`394`	`395`	`/**`