JS SDK - Add type Infer for displaySettings #181
Conversation
|
|
GiangNT95
force-pushed
the
feature/CMS-47083-JS-SDK-Add-type-Infer-for-displaySettings
branch
from
e143c50 to
1080571
Compare
GiangNT95
force-pushed
the
feature/CMS-47083-JS-SDK-Add-type-Infer-for-displaySettings
branch
from
f2d10ca to
d1f56e5
Compare
GiangNT95
force-pushed
the
feature/CMS-47083-JS-SDK-Add-type-Infer-for-displaySettings
branch
from
d1f56e5 to
2a93a47
Compare
GiangNT95
force-pushed
the
feature/CMS-47083-JS-SDK-Add-type-Infer-for-displaySettings
branch
from
2a93a47 to
fa2268a
Compare
Feature: CMS-47083
GiangNT95
force-pushed
the
feature/CMS-47083-JS-SDK-Add-type-Infer-for-displaySettings
branch
from
fa2268a to
aae4148
Compare
Feature: CMS-47083
GiangNT95
force-pushed
the
feature/CMS-47083-JS-SDK-Add-type-Infer-for-displaySettings
branch
from
aae4148 to
37d442f
Compare
| }); | ||
|
|
||
| if (!Component) { | ||
| console.log( |
There was a problem hiding this comment.
This was removed my a previous PR. Maybe rebase the branch again?
| settings: DisplaySettingsType[] | null | undefined, | ||
| templateSettings: Record<string, { editor: string; choices: Record<string, any> }> | ||
| ): Record<string, string> { | ||
| if (!settings || settings.length === 0) return {}; |
There was a problem hiding this comment.
We should return undefined instead of an empty {}.
|
|
||
| const parsedDisplaySettings = template | ||
| ? parseDisplaySettings(node.displaySettings, template.settings) | ||
| : {}; |
There was a problem hiding this comment.
Again here. We should return undefined if there is no displaySettings returned
| // Assign the value to the key in the result object | ||
| result[item.key] = item.value; | ||
| } | ||
| settings.forEach(s => { |
There was a problem hiding this comment.
On the second thought we might not need to do this while parsing. Lets stick to the older way where we just did something like this
for (const item of displaySettings) {
// Assign the value to the key in the result object
result[item.key] = item.value;
}
| return undefined; // Return undefined if displaySettings is not provided | ||
| } | ||
| settings: DisplaySettingsType[] | null | undefined, | ||
| templateSettings: Record<string, { editor: string; choices: Record<string, any> }> |
There was a problem hiding this comment.
lets stick to old way where we take just settings (a displaySettings)
Feature: CMS-47083
Feature: CMS-47083