feat: migrate to TypeScript and ESM #266
Conversation
| matrix: | ||
| eslint: [8] | ||
| node: [12.22.0, 12, 14.17.0, 14, 16.0.0, 16, 18.0.0, 18, 20, 22, 24] | ||
| node: [22, 24] |
There was a problem hiding this comment.
Removing these entries from the CI matrix, when the engines list haven't been reduced is creating a blind spot. Is there a reason these versions were dropped?
There was a problem hiding this comment.
The actual build process as well as the unit-tests need --experimental-transform-types and/or --experimental-strip-types which are not available on the older versions of Node.js. Also building, testing and type checking on that many versions of Node might be a bit excessive. We could use this oppurtunity to update the engines field as well but if we really want to go that far back in Node versions then I think I might have to switch things around and maybe switch to a vitest or some other testing framework.
aryaemami59
force-pushed
the
ts-migration
branch
4 times, most recently
from
31435fc to
cd41035
Compare
aryaemami59
force-pushed
the
ts-migration
branch
from
cd41035 to
3b43470
Compare
2 participants
This PR: