Revise the "What's next" section to focus on two separate paths #980
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ronaldngounou The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @ronaldngounou. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ronaldngounou
force-pushed
the
update-quickstart
branch
from
60aba98 to
b92baa2
Compare
Signed-off-by: Ronald Ngounou <[email protected]>
Signed-off-by: Ronald Ngounou <[email protected]>
Signed-off-by: Ronald Ngounou <[email protected]>
Signed-off-by: Ronald Ngounou <[email protected]>
Signed-off-by: Ronald Ngounou <[email protected]>
Signed-off-by: Ronald Ngounou <[email protected]>
ronaldngounou
force-pushed
the
update-quickstart
branch
from
b92baa2 to
0ae2c81
Compare
|
I took in consideration the modifications to be made in this issue when updating the Quickstart page. PR #981 |
Signed-off-by: Ronald Ngounou <[email protected]>
Signed-off-by: Ronald Ngounou <[email protected]>
There was a problem hiding this comment.
This file shouldn't be in the commit
There was a problem hiding this comment.
Adding package.json to your gitignore doesn't seem to have helped.
Incidentally, version upgrades should be a separate PR from content.
| title: Quickstart | ||
| weight: 900 | ||
| description: Get etcd up and running in less than 5 minutes! | ||
| description: Run etcd Locally Under 5 minutes! |
There was a problem hiding this comment.
This isn't a better title. Please revert to the original title.
| Install `etcd` from pre-built binaries using cURL. | ||
|
|
||
| ```console | ||
| $ etcdctl put greeting "Hello, etcd" | ||
| OK | ||
| ``` | ||
| ```bash | ||
| # Download and extract the latest release using cURL | ||
| curl -L https://github.com/etcd-io/etcd/releases/download/v3.5.21/etcd-v3.5.21-linux-arm64.tar.gz \ | ||
| -o etcd.tar.gz | ||
| tar -xvf etcd.tar.gz | ||
| cd etcd-v3.5.21-linux-arm64 |
There was a problem hiding this comment.
This change reverts an improvement we made a couple years ago, where all installation instructions funnel through the Install page. It's not a good idea; we don't want to go back to having different installation instructions in the Quickstart than we have elsewhere.
There was a problem hiding this comment.
This looks like you somehow got an old checkout.
| - If you are a developer: | ||
| - Explore the gRPC [API](/docs/v3.5/learning/api). | ||
| - Set up a [multi-machine cluster](/docs/v3.5/op-guide/clustering). | ||
|
|
||
| If you are an operator or admin: | ||
|
|
||
| - Learn how to [configure](/docs/v3.5/op-guide/configuration) etcd. | ||
| - Find language [bindings and tools](/docs/v3.5/integrations). | ||
| - Use TLS to [secure](/docs/v3.5/op-guide/security) an etcd cluster. | ||
| - [Tune etcd](/docs/v3.5/tuning). |
There was a problem hiding this comment.
This is the good part of the PR. Can you open an new PR that has just these changes?
| [Install]: ../install/ | ||
| - If you are a developer: | ||
| - Explore the gRPC [API](/docs/v3.5/learning/api). | ||
| - Set up a [multi-machine cluster](/docs/v3.5/op-guide/clustering). |
There was a problem hiding this comment.
This should probably go in the operator section, rather than the developer section.
| If you are an operator or admin: | ||
|
|
||
| - Learn how to [configure](/docs/v3.5/op-guide/configuration) etcd. | ||
| - Find language [bindings and tools](/docs/v3.5/integrations). |
There was a problem hiding this comment.
This should probably go in the Developer section.
3 participants
Task
This PR contributes to the issue #782
(3) Revise the "What's next" section to focus on two separate paths, Development and Operations.
I will create a separate PR for the task (2) Add a prerequisities section.
Testing