Update primitive.yaml: Add Bytes primitive #484
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in ethereum/builder-specs#107 (comment) (/cc @lucassaldanha). I agree with Lucas that Bitvector is probably wrong, and that currently we don't have a good primitive to express this.
I'm also not terribly familiar with the beacon API types though, so am open to other options, both in naming and format.
Some points of discussion:
ByteVector?{2,}(which I started with) or{0,}since before the latest changes to EIP-7865 the empty requests were encoded as"0x"which{2,}doesn't allow.sizeof(largest request type) * max_request_count_per_block + 1but that seemed to get really deep in the weeds for a field thats meany to be opaque for most purposes.