Skip to content

yulrun: Move dialect check of parse step after analyze #16112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

yulrun: Move dialect check of parse step after analyze #16112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/tools/yulrun.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ std::pair<std::shared_ptr<AST const>, std::shared_ptr<AsmAnalysisInfo>> parse(st
solidity::frontend::OptimiserSettings::none(),
DebugInfoSelection::Default()
);
auto const* evmDialect = dynamic_cast<EVMDialect const*>(&stack.dialect());
// TODO: Add EOF support
solUnimplementedAssert(evmDialect && !evmDialect->eofVersion(), "No EOF support for yulrun yet.");
if (stack.parseAndAnalyze("--INPUT--", _source))
{
auto const* evmDialect = dynamic_cast<EVMDialect const*>(&stack.dialect());
// TODO: Add EOF support
solUnimplementedAssert(evmDialect && !evmDialect->eofVersion(), "No EOF support for yulrun yet.");
yulAssert(!Error::hasErrorsWarningsOrInfos(stack.errors()), "Parsed successfully but had errors.");
return make_pair(stack.parserResult()->code(), stack.parserResult()->analysisInfo);
}
Expand Down