Skip to content

test(events): add synctest to subscriber tests #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+49 −48
Open

test(events): add synctest to subscriber tests #5266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06cb5d
test(events): add synctest to subscriber tests
akrem-chabchoub Oct 29, 2025
215bd88
test(storer): remove parallelization from subscriber test
akrem-chabchoub Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,17 @@ endif
.PHONY: test-ci
test-ci:
ifdef cover
$(GO) test -run "[^FLAKY]$$" -coverprofile=cover.out ./...
$(GO) test -run "[^FLAKY]$$" -coverprofile=cover.out ./pkg/storer/internal/events
else
$(GO) test -run "[^FLAKY]$$" ./...
$(GO) test -run "[^FLAKY]$$" ./pkg/storer/internal/events
endif

.PHONY: test-ci-race
test-ci-race:
ifdef cover
$(GO) test -race -run "[^FLAKY]$$" -coverprofile=cover.out ./...
$(GO) test -race -run "[^FLAKY]$$" -coverprofile=cover.out ./pkg/storer/internal/events
else
$(GO) test -race -run "[^FLAKY]$$" ./...
$(GO) test -race -run "[^FLAKY]$$" ./pkg/storer/internal/events
endif

.PHONY: test-ci-flaky
Expand Down
89 changes: 45 additions & 44 deletions pkg/storer/internal/events/subscribe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,54 +6,55 @@ package events_test

import (
"testing"
"testing/synctest"
"time"

"github.com/ethersphere/bee/v2/pkg/storer/internal/events"
)

func TestSubscriber(t *testing.T) {
t.Parallel()

s := events.NewSubscriber()

bin0_1, unsub0_1 := s.Subscribe("0")
bin0_2, unsub0_2 := s.Subscribe("0")
t.Cleanup(func() { unsub0_1(); unsub0_2() })
go s.Trigger("0")

gotSignals := make(chan struct{})

go func() {
defer close(gotSignals)
<-bin0_1
<-bin0_2
}()

select {
case <-gotSignals:
case <-time.After(time.Second):
t.Fatal("signals did not fire in time")
}

select {
case <-bin0_1:
t.Fatalf("trigger should not have fired again")
case <-bin0_2:
t.Fatalf("trigger should not have fired again")
default:
}

bin1, unsub1 := s.Subscribe("1")
go s.Trigger("1")
go s.Trigger("1")
<-bin1
<-bin1

unsub1()

select {
case <-bin1:
t.Fatalf("trigger should not have fired again")
default:
}
synctest.Test(t, func(t *testing.T) {
s := events.NewSubscriber()

bin0_1, unsub0_1 := s.Subscribe("0")
bin0_2, unsub0_2 := s.Subscribe("0")
t.Cleanup(func() { unsub0_1(); unsub0_2() })
go s.Trigger("0")

gotSignals := make(chan struct{})

go func() {
defer close(gotSignals)
<-bin0_1
<-bin0_2
}()

select {
case <-gotSignals:
case <-time.After(time.Second):
t.Fatal("signals did not fire in time")
}

select {
case <-bin0_1:
t.Fatalf("trigger should not have fired again")
case <-bin0_2:
t.Fatalf("trigger should not have fired again")
default:
}

bin1, unsub1 := s.Subscribe("1")
go s.Trigger("1")
go s.Trigger("1")
<-bin1
<-bin1

unsub1()

select {
case <-bin1:
t.Fatalf("trigger should not have fired again")
default:
}
})
}
Loading