Skip to content

Commit 21120b0

Browse files
authored
Merge pull request #199 from fabric-testbed/br198
use user specified vlan for fabnet FPs
2 parents cd52ed5 + b51c1e2 commit 21120b0

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

fabric_cf/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__VERSION__ = "1.2.7"
1+
__VERSION__ = "1.2.8"

fabric_cf/actor/core/policy/network_service_inventory.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,20 @@ def allocate_ifs(self, *, requested_ns: NetworkServiceSliver, requested_ifs: Int
170170
if vlan_range is not None:
171171
vlan_range = self.__exclude_allocated_vlans(available_vlan_range=vlan_range, bqm_ifs=bqm_ifs,
172172
existing_reservations=existing_reservations)
173+
if bqm_ifs.get_type() != InterfaceType.FacilityPort:
174+
# Allocate the first available VLAN
175+
requested_ifs.labels.vlan = str(vlan_range[0])
176+
requested_ifs.label_allocations = Labels(vlan=str(vlan_range[0]))
177+
else:
178+
if requested_ifs.labels is None or requested_ifs.labels.vlan is None:
179+
return requested_ifs
180+
181+
if requested_ifs.labels.vlan not in vlan_range:
182+
raise BrokerException(error_code=ExceptionErrorCode.FAILURE,
183+
msg=f"Vlan for L3 service {requested_ifs.labels.vlan} "
184+
f"is outside the available range "
185+
f"{vlan_range}")
173186

174-
# Allocate the first available VLAN
175-
requested_ifs.labels.vlan = str(vlan_range[0])
176-
requested_ifs.label_allocations = Labels(vlan=str(vlan_range[0]))
177187
break
178188
return requested_ifs
179189

0 commit comments

Comments
 (0)