types-first recheck skipping test

Summary: test for recheck skipping in types-first

Reviewed By: nmote

Differential Revision: D15246616

fbshipit-source-id: bea29e01e6a22a51b100380467e10c7242355e8c

Author: avikchaudhuri

runtests.sh

@@ -40,6 +40,17 @@ assert_errors() {
   assert_exit_on_line "${BASH_LINENO[0]}" "$EXIT_ERRS" "$@"
 }
 
+show_skipping_stats_classic() {
+  printf "\\n========Skipping stats========\\n"
+  grep -o "Merge skipped [0-9]\+ of [0-9]\+ modules" $1 | tail -n 1
+}
+
+show_skipping_stats_types_first() {
+  printf "\\n========Skipping stats========\\n"
+  grep -o "Merge skipped [0-9]\+ of [0-9]\+ modules" $1 | tail -n 1
+  grep -o "Check will skip [0-9]\+ files" $1 | tail -n 1
+}
+
 show_help() {
   printf "Usage: runtests.sh [-hlqrv] [-d DIR] [-t TEST] [-b] FLOW_BINARY [[-f] TEST_FILTER]\n\n"
   printf "Runs Flow's tests.\n\n"

tests/types-first-skip-recheck/.flowconfig

@@ -0,0 +1,2 @@
+[ignore]
+<PROJECT_ROOT>/tmp*

tests/types-first-skip-recheck/.testconfig

@@ -0,0 +1,2 @@
+auto_start: false
+shell: test.sh

tests/types-first-skip-recheck/test.sh

@@ -0,0 +1,25 @@
+#!/bin/bash
+
+mkdir tmp
+cp test1.js tmp/
+
+printf "\\nServer should start in types-first mode\\n"
+start_flow . --types-first
+assert_errors "$FLOW" status --strip-root
+
+printf "\\nAdding a line should cause minimal rechecking (but preserve errors)\\n"
+cp tmp1/test1.js test1.js
+assert_ok "$FLOW" force-recheck --focus test1.js
+assert_errors "$FLOW" status --strip-root
+show_skipping_stats_types_first "$FLOW_LOG_FILE"
+
+printf "\\nAdding a comment should cause minimal rechecking (but preserve errors)\\n"
+cp tmp2/test1.js test1.js
+assert_ok "$FLOW" force-recheck --focus test1.js
+assert_errors "$FLOW" status --strip-root
+show_skipping_stats_types_first "$FLOW_LOG_FILE"
+
+assert_ok "$FLOW" stop
+
+cp tmp/test1.js test1.js
+rm -rf tmp

tests/types-first-skip-recheck/test1.js

@@ -0,0 +1,5 @@
+// @flow
+
+export type T = string;
+
+module.exports = 0;

tests/types-first-skip-recheck/test2.js

@@ -0,0 +1,5 @@
+// @flow
+
+(require('./test1'): string);
+import type { T } from './test1';
+export type S = T;

tests/types-first-skip-recheck/test3.js

@@ -0,0 +1,7 @@
+// @flow
+
+import type { S } from './test2';
+
+(0: string);
+
+export type R = S;

tests/types-first-skip-recheck/tmp1/test1.js

@@ -0,0 +1,6 @@
+// @flow
+
+export type T = string;
+
+
+module.exports = 0;

tests/types-first-skip-recheck/tmp2/test1.js

@@ -0,0 +1,6 @@
+// @flow
+
+export type T = string; //
+
+
+module.exports = 0;

tests/types-first-skip-recheck/types-first-skip-recheck.exp

@@ -0,0 +1,113 @@
+
+Server should start in types-first mode
+Error ----------------------------------------------------------------------------------------------------- test2.js:3:2
+
+Cannot cast `require(...)` to string because number [1] is incompatible with string [2].
+
+   test2.js:3:2
+   3| (require('./test1'): string);
+       ^^^^^^^^^^^^^^^^^^
+
+References:
+   test1.js:5:18
+   5| module.exports = 0;
+                       ^ [1]
+   test2.js:3:22
+   3| (require('./test1'): string);
+                           ^^^^^^ [2]
+
+
+Error ----------------------------------------------------------------------------------------------------- test3.js:5:2
+
+Cannot cast `0` to string because number [1] is incompatible with string [2].
+
+   test3.js:5:2
+   5| (0: string);
+       ^ [1]
+
+References:
+   test3.js:5:5
+   5| (0: string);
+          ^^^^^^ [2]
+
+
+
+Found 2 errors
+
+Adding a line should cause minimal rechecking (but preserve errors)
+Error ----------------------------------------------------------------------------------------------------- test2.js:3:2
+
+Cannot cast `require(...)` to string because number [1] is incompatible with string [2].
+
+   test2.js:3:2
+   3| (require('./test1'): string);
+       ^^^^^^^^^^^^^^^^^^
+
+References:
+   test1.js:6:18
+   6| module.exports = 0;
+                       ^ [1]
+   test2.js:3:22
+   3| (require('./test1'): string);
+                           ^^^^^^ [2]
+
+
+Error ----------------------------------------------------------------------------------------------------- test3.js:5:2
+
+Cannot cast `0` to string because number [1] is incompatible with string [2].
+
+   test3.js:5:2
+   5| (0: string);
+       ^ [1]
+
+References:
+   test3.js:5:5
+   5| (0: string);
+          ^^^^^^ [2]
+
+
+
+Found 2 errors
+
+========Skipping stats========
+Merge skipped 1 of 3 modules
+Check will skip 1 files
+
+Adding a comment should cause minimal rechecking (but preserve errors)
+Error ----------------------------------------------------------------------------------------------------- test2.js:3:2
+
+Cannot cast `require(...)` to string because number [1] is incompatible with string [2].
+
+   test2.js:3:2
+   3| (require('./test1'): string);
+       ^^^^^^^^^^^^^^^^^^
+
+References:
+   test1.js:6:18
+   6| module.exports = 0;
+                       ^ [1]
+   test2.js:3:22
+   3| (require('./test1'): string);
+                           ^^^^^^ [2]
+
+
+Error ----------------------------------------------------------------------------------------------------- test3.js:5:2
+
+Cannot cast `0` to string because number [1] is incompatible with string [2].
+
+   test3.js:5:2
+   5| (0: string);
+       ^ [1]
+
+References:
+   test3.js:5:5
+   5| (0: string);
+          ^^^^^^ [2]
+
+
+
+Found 2 errors
+
+========Skipping stats========
+Merge skipped 2 of 3 modules
+Check will skip 2 files