Add missing attempts++ in ShadowNode with MAX_COMMIT_ATTEMPTS_BEFORE_LOCKING (#52673)

cortinico · facebook-github-bot · commit 847721dc9bac · 2025-07-17T09:02:19.000-07:00
Summary: Pull Request resolved: #52673 We should be incrementing the `attempts` variable as otherwise this loop with never stop. Created from CodeHub with https://fburl.com/edit-in-codehub Changelog: [Internal] - Reviewed By: rubennorte Differential Revision: D78487202 fbshipit-source-id: 91d7f5d88a90bdfa806195fd35897f2f51c1deb9
diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp
@@ -251,6 +251,7 @@ CommitStatus ShadowTree::commit(
       if (status != CommitStatus::Failed) {
         return status;
       }
+      attempts++;
     }
 
     {

Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,7 @@ CommitStatus ShadowTree::commit(`
`251`	`251`	`if (status != CommitStatus::Failed) {`
`252`	`252`	`return status;`
`253`	`253`	`}`
	`254`	`+ attempts++;`
`254`	`255`	`}`
`255`	`256`
`256`	`257`	`{`