Commit 8a31acb
Android: Add new configuration for
Summary:
Following the [RFC](react-native-community/discussions-and-proposals#925), this PR adds new `DevMenuConfiguration` object and extends `ReactHost` API for passing settings to the particular `DevSupportManager`. The `DevMenuConfiguration` includes:
- isDevMenuEnabled,
- isShakeGestureEnabled,
- areKeyboardShortcutsEnabled,
## Changelog:
[ANDROID][ADDED] - Add new configuration for `RCTDevMenu`
Test Plan:
Tested with different configuration on `DevMenuConfiguration`:
<details>
<summary>Click to view code</summary>
```kt
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
fullyDrawnReporter.addReporter()
maybeUpdateBackgroundColor()
reactDelegate?.reactHost?.let { reactHost ->
val devMenuConfiguration = DevMenuConfiguration(
isDevMenuEnabled = true,
isShakeGestureEnabled = false,
areKeyboardShortcutsEnabled = false,
)
reactHost.setDevMenuConfiguration(devMenuConfiguration)
}
// register insets listener to update margins on the ReactRootView to avoid overlap w/ system
// bars
reactDelegate?.reactRootView?.let { rootView ->
val insetsType: Int =
WindowInsetsCompat.Type.systemBars() or WindowInsetsCompat.Type.displayCutout()
val windowInsetsListener = { view: View, windowInsets: WindowInsetsCompat ->
val insets = windowInsets.getInsets(insetsType)
(view.layoutParams as FrameLayout.LayoutParams).apply {
setMargins(insets.left, insets.top, insets.right, insets.bottom)
}
WindowInsetsCompat.CONSUMED
}
ViewCompat.setOnApplyWindowInsetsListener(rootView, windowInsetsListener)
}
}
```
</details>
Differential Revision: D81684310
Pulled By: coadoDevSupportManager (#53557)1 parent 094794a commit 8a31acb
File tree
9 files changed
+141
-10
lines changed- packages
- react-native/ReactAndroid
- api
- src/main/java/com/facebook/react
- devsupport
- interfaces
- runtime
- rn-tester/android/app/src/main/java/com/facebook/react/uiapp
9 files changed
+141
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
| 242 | + | |
242 | 243 | | |
243 | 244 | | |
244 | 245 | | |
| |||
1895 | 1896 | | |
1896 | 1897 | | |
1897 | 1898 | | |
| 1899 | + | |
| 1900 | + | |
| 1901 | + | |
| 1902 | + | |
| 1903 | + | |
| 1904 | + | |
| 1905 | + | |
| 1906 | + | |
| 1907 | + | |
1898 | 1908 | | |
1899 | 1909 | | |
1900 | 1910 | | |
| |||
1936 | 1946 | | |
1937 | 1947 | | |
1938 | 1948 | | |
| 1949 | + | |
1939 | 1950 | | |
1940 | 1951 | | |
1941 | 1952 | | |
1942 | 1953 | | |
1943 | 1954 | | |
| 1955 | + | |
1944 | 1956 | | |
1945 | 1957 | | |
1946 | 1958 | | |
1947 | 1959 | | |
1948 | 1960 | | |
1949 | 1961 | | |
| 1962 | + | |
1950 | 1963 | | |
1951 | 1964 | | |
1952 | 1965 | | |
| |||
1965 | 1978 | | |
1966 | 1979 | | |
1967 | 1980 | | |
| 1981 | + | |
1968 | 1982 | | |
1969 | 1983 | | |
1970 | 1984 | | |
| 1985 | + | |
1971 | 1986 | | |
1972 | 1987 | | |
1973 | 1988 | | |
1974 | 1989 | | |
1975 | 1990 | | |
| 1991 | + | |
1976 | 1992 | | |
1977 | 1993 | | |
1978 | 1994 | | |
| |||
2029 | 2045 | | |
2030 | 2046 | | |
2031 | 2047 | | |
| 2048 | + | |
2032 | 2049 | | |
2033 | 2050 | | |
2034 | 2051 | | |
| 2052 | + | |
2035 | 2053 | | |
2036 | 2054 | | |
2037 | 2055 | | |
2038 | 2056 | | |
2039 | 2057 | | |
| 2058 | + | |
2040 | 2059 | | |
2041 | 2060 | | |
2042 | 2061 | | |
| |||
2053 | 2072 | | |
2054 | 2073 | | |
2055 | 2074 | | |
| 2075 | + | |
2056 | 2076 | | |
2057 | 2077 | | |
2058 | 2078 | | |
| 2079 | + | |
2059 | 2080 | | |
| 2081 | + | |
2060 | 2082 | | |
2061 | 2083 | | |
2062 | 2084 | | |
| |||
2131 | 2153 | | |
2132 | 2154 | | |
2133 | 2155 | | |
| 2156 | + | |
2134 | 2157 | | |
2135 | 2158 | | |
2136 | 2159 | | |
| 2160 | + | |
2137 | 2161 | | |
2138 | 2162 | | |
2139 | 2163 | | |
2140 | 2164 | | |
2141 | 2165 | | |
| 2166 | + | |
2142 | 2167 | | |
2143 | 2168 | | |
2144 | 2169 | | |
| |||
2155 | 2180 | | |
2156 | 2181 | | |
2157 | 2182 | | |
| 2183 | + | |
2158 | 2184 | | |
2159 | 2185 | | |
2160 | 2186 | | |
| 2187 | + | |
2161 | 2188 | | |
| 2189 | + | |
2162 | 2190 | | |
2163 | 2191 | | |
2164 | 2192 | | |
| |||
3071 | 3099 | | |
3072 | 3100 | | |
3073 | 3101 | | |
| 3102 | + | |
3074 | 3103 | | |
3075 | 3104 | | |
3076 | 3105 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
393 | 393 | | |
394 | 394 | | |
395 | 395 | | |
396 | | - | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
397 | 401 | | |
398 | 402 | | |
399 | 403 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
189 | 190 | | |
190 | 191 | | |
191 | 192 | | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
192 | 196 | | |
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
Lines changed: 40 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
132 | 148 | | |
133 | 149 | | |
134 | 150 | | |
| |||
172 | 188 | | |
173 | 189 | | |
174 | 190 | | |
| 191 | + | |
175 | 192 | | |
176 | 193 | | |
177 | 194 | | |
| |||
187 | 204 | | |
188 | 205 | | |
189 | 206 | | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
190 | 210 | | |
191 | 211 | | |
192 | 212 | | |
| |||
325 | 345 | | |
326 | 346 | | |
327 | 347 | | |
328 | | - | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
329 | 354 | | |
330 | 355 | | |
331 | 356 | | |
| |||
888 | 913 | | |
889 | 914 | | |
890 | 915 | | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
891 | 927 | | |
892 | 928 | | |
893 | 929 | | |
| |||
897 | 933 | | |
898 | 934 | | |
899 | 935 | | |
900 | | - | |
901 | | - | |
902 | | - | |
903 | | - | |
904 | | - | |
| 936 | + | |
| 937 | + | |
905 | 938 | | |
906 | 939 | | |
907 | 940 | | |
| |||
955 | 988 | | |
956 | 989 | | |
957 | 990 | | |
958 | | - | |
959 | | - | |
| 991 | + | |
960 | 992 | | |
961 | 993 | | |
962 | 994 | | |
| |||
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
74 | 86 | | |
75 | 87 | | |
76 | 88 | | |
| |||
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
39 | 51 | | |
40 | 52 | | |
41 | 53 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
366 | 367 | | |
367 | 368 | | |
368 | 369 | | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
369 | 376 | | |
370 | 377 | | |
371 | 378 | | |
| |||
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
69 | 80 | | |
70 | 81 | | |
71 | 82 | | |
| |||
0 commit comments