add support for application/x-www-form-urlencoded (#37)

Co-authored-by: yohayg <[email protected]>

Author: yohayg

index.js

@@ -62,6 +62,9 @@ module.exports = (opts) => {
           } else if (typeof req.body === 'string') {
             body = req.body
             populateHeaders(headers, body, 'text/plain')
+          } else if (headers['content-type'] === 'application/x-www-form-urlencoded') {
+            body = querystring.stringify(req.body)
+            populateHeaders(headers, body, 'application/x-www-form-urlencoded')
           } else {
             body = JSON.stringify(req.body)
             populateHeaders(headers, body, 'application/json')

test/1.smoke.test.js

@@ -3,7 +3,7 @@
 
 const request = require('supertest')
 const bodyParser = require('body-parser')
-const expect = require('chai').expect
+const { expect } = require('chai')
 let gateway, service, close, proxy, gHttpServer
 
 describe('fast-proxy smoke', () => {
@@ -22,6 +22,8 @@ describe('fast-proxy smoke', () => {
     // init gateway
     gateway = require('restana')()
     gateway.use(bodyParser.json())
+    gateway.use(bodyParser.urlencoded({ extended: true }))
+    gateway.use(bodyParser.text())
 
     gateway.all('/service/*', function (req, res) {
       proxy(req, res, req.url, {})
@@ -46,11 +48,18 @@ describe('fast-proxy smoke', () => {
     // init remote service
     service = require('restana')()
     service.use(bodyParser.json())
-
+    service.use(bodyParser.urlencoded({ extended: true }))
+    service.use(bodyParser.text())
     service.get('/service/get', (req, res) => res.send('Hello World!'))
     service.post('/service/post', (req, res) => {
       res.send(req.body)
     })
+    service.post('/service/post/urlencoded', (req, res) => {
+      res.send(req.body)
+    })
+    service.post('/service/post/text', (req, res) => {
+      res.send(req.body)
+    })
     service.get('/service/headers', (req, res) => {
       res.setHeader('x-agent', 'fast-proxy')
       res.setHeader('host', req.headers.host)
@@ -74,7 +83,18 @@ describe('fast-proxy smoke', () => {
       .expect(200)
   })
 
-  it('should 200 on POST to valid remote endpoint', async () => {
+  it('should 200 on POST plain/text to valid remote endpoint', async () => {
+    await request(gHttpServer)
+      .post('/service/post/text')
+      .set('content-type', 'text/plain')
+      .send('name is john')
+      .expect(200)
+      .then((res) => {
+        expect(res.text).to.equal('name is john')
+      })
+  })
+
+  it('should 200 on POST application/json to valid remote endpoint', async () => {
     await request(gHttpServer)
       .post('/service/post')
       .send({ name: 'john' })
@@ -84,6 +104,16 @@ describe('fast-proxy smoke', () => {
       })
   })
 
+  it('should 200 on POST application/x-www-form-urlencoded to valid remote endpoint', async () => {
+    await request(gHttpServer)
+      .post('/service/post/urlencoded')
+      .send('name=john')
+      .expect(200)
+      .then((res) => {
+        expect(res.body.name).to.equal('john')
+      })
+  })
+
   it('should 200 on GET /servive/headers', async () => {
     await request(gHttpServer)
       .get('/service/headers?query=string')

test/5.undici.test.js

@@ -3,7 +3,7 @@
 
 const request = require('supertest')
 const bodyParser = require('body-parser')
-const expect = require('chai').expect
+const { expect } = require('chai')
 let gateway, service, close, proxy, gHttpServer
 
 describe('undici', () => {
@@ -24,7 +24,7 @@ describe('undici', () => {
   it('init & start gateway', async () => {
     // init gateway
     gateway = require('restana')()
-
+    gateway.use(bodyParser.json())
     gateway.all('/service/*', function (req, res) {
       proxy(req, res, req.url, {})
     })
@@ -58,14 +58,15 @@ describe('undici', () => {
   it('should 200 on POST to valid remote endpoint', async () => {
     await request(gHttpServer)
       .post('/service/post')
-      .send({ name: 'john' })
+      .set('Content-Type', 'application/json')
+      .send('{"name":"john"}')
       .expect(200)
       .then((res) => {
         expect(res.body.name).to.equal('john')
       })
   })
 
-  it('should 200 on GET /servive/headers', async () => {
+  it('should 200 on GET /service/headers', async () => {
     await request(gHttpServer)
       .get('/service/headers')
       .expect(200)