From c623f892940b21dd134de43486201c8bd63249cb Mon Sep 17 00:00:00 2001
From: Mohammed Omer <info@mohammedomer.vip>
Date: Fri, 20 Dec 2024 10:22:10 +0530
Subject: [PATCH] Optimize skunk.gemspec: Streamlined gem specification and
 cleaned metadata and file handling.

I optimized the skunk.gemspec by simplifying the required_ruby_version to a string format for clarity, streamlined the metadata handling to only include necessary sections, and improved the file inclusion process for efficiency. I also clarified comments for better understanding. These changes enhance readability, reduce redundancy, and ensure the file is easier to maintain and extend in the future.
---
 skunk.gemspec | 33 +++++++++++++--------------------
 1 file changed, 13 insertions(+), 20 deletions(-)

diff --git a/skunk.gemspec b/skunk.gemspec
index 732e68b..ce5852b 100644
--- a/skunk.gemspec
+++ b/skunk.gemspec
@@ -14,33 +14,26 @@ Gem::Specification.new do |spec|
   spec.description   = "Knows how to calculate the SkunkScore for a set of Ruby modules"
   spec.homepage      = "https://github.com/fastruby/skunk"
 
-  spec.required_ruby_version = [">= 2.4.0"]
-
-  # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
-  # to allow pushing to a single host or delete this section to allow pushing to any host.
-  if spec.respond_to?(:metadata)
-    spec.metadata["allowed_push_host"] = "https://www.rubygems.org"
-
-    spec.metadata["homepage_uri"] = spec.homepage
-    spec.metadata["source_code_uri"] = "https://github.com/fastruby/skunk"
-    spec.metadata["changelog_uri"] = "https://github.com/fastruby/skunk/blob/main/CHANGELOG.md"
-  else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
-  end
-
-  # Specify which files should be added to the gem when it is released.
-  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(bin|test|spec|features)/}) }
-  end
+  spec.required_ruby_version = ">= 2.4.0"
+
+  # Prevent pushing this gem to RubyGems.org unless specified
+  spec.metadata["allowed_push_host"] = "https://www.rubygems.org" if spec.respond_to?(:metadata)
+
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = "https://github.com/fastruby/skunk"
+  spec.metadata["changelog_uri"] = "https://github.com/fastruby/skunk/blob/main/CHANGELOG.md"
+
+  # Specify which files should be added to the gem
+  spec.files = Dir.chdir(__dir__) { `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(bin|test|spec|features)/}) } }
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  # Dependencies
   spec.add_dependency "rubycritic", ">= 4.5.2", "< 5.0"
   spec.add_dependency "terminal-table", "~> 3.0"
 
+  # Development dependencies
   spec.add_development_dependency "codecov", "~> 0.1.16"
   spec.add_development_dependency "debug"
   spec.add_development_dependency "minitest", "< 6"