Only try fetch the main service instead of all of them (#597)

Author: eberlep

controllers/postgres_controller.go

@@ -208,7 +208,7 @@ func (r *PostgresReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 			log.V(debugLogLevel).Info("finalizer from storage encryption secret removed")
 		}
 
-		deletable, err := r.OperatorManager.IsOperatorDeletable(ctx, namespace)
+		deletable, err := r.OperatorManager.IsOperatorDeletable(ctx, namespace, instance.ToPeripheralResourceName())
 		if err != nil {
 			r.recorder.Eventf(instance, "Warning", "Error", "failed to check if the operator is idle: %v", err)
 			return ctrl.Result{}, fmt.Errorf("error while checking if the operator is idle: %w", err)

pkg/operatormanager/operatormanager.go

@@ -161,7 +161,7 @@ func (m *OperatorManager) InstallOrUpdateOperator(ctx context.Context, namespace
 }
 
 // IsOperatorDeletable returns true when there's no running instance operated by the operator
-func (m *OperatorManager) IsOperatorDeletable(ctx context.Context, namespace string) (bool, error) {
+func (m *OperatorManager) IsOperatorDeletable(ctx context.Context, namespace string, name string) (bool, error) {
 	log := m.log.WithValues("ns", namespace)
 
 	setList := &appsv1.StatefulSetList{}
@@ -173,12 +173,14 @@ func (m *OperatorManager) IsOperatorDeletable(ctx context.Context, namespace str
 		return false, nil
 	}
 
-	services := &corev1.ServiceList{}
-	if err := m.client.List(ctx, services, client.InNamespace(namespace), m.toInstanceMatchingLabels()); client.IgnoreNotFound(err) != nil {
-		return false, fmt.Errorf("error while fetching the list of services operated by the operator: %w", err)
+	// Try fetch service
+	ns := types.NamespacedName{
+		Namespace: namespace,
+		Name:      name,
 	}
-	if len(services.Items) != 0 {
-		log.Info("services still running")
+	err := m.client.Get(ctx, ns, &corev1.Service{})
+	if !errors.IsNotFound(err) {
+		log.Info("service still running")
 		return false, nil
 	}