Skip to content

Commit 7e29e53

Browse files
committed
Be idempotent
1 parent cdb38cf commit 7e29e53

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

.github/workflows/pull_request.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,37 +23,37 @@ jobs:
2323
# version: v1.32.2
2424
# args: --timeout=5m
2525

26+
- name: Get Kubebuilder Version
27+
id: get-kubebuilder-version
28+
run: echo "::set-output name=version::$(make kubebuilder-version-ci)"
29+
shell: bash
30+
2631
- name: Ensure etcd
2732
id: Ensure-etcd
2833
uses: actions/cache@v2
2934
with:
3035
path: ~/go/bin/etcd
31-
key: etcd
36+
key: ${{ runner.os }}-kubebuilder-${{ steps.get-kubebuilder-version.outputs.version }}-etcd
3237

3338
- name: Ensure kube-apiserver
3439
id: ensure-kube-apiserver
3540
uses: actions/cache@v2
3641
with:
3742
path: ~/go/bin/kube-apiserver
38-
key: kube-apiserver
39-
40-
- name: Get Kubebuilder Version
41-
id: get-kubebuilder-version
42-
run: echo "::set-output name=version::$(make kubebuilder-version-ci)"
43-
shell: bash
43+
key: ${{ runner.os }}-kubebuilder-${{ steps.get-kubebuilder-version.outputs.version }}-kube-apiserver
4444

4545
- name: Ensure Kubebuilder Metadata
4646
id: ensure-kubebuilder-metadata
4747
uses: actions/cache@v2
4848
with:
4949
path: ~/.kubebuilder/${{ steps.get-kubebuilder-version.outputs.version }}
50-
key: kubebuilder
50+
key: ${{ runner.os }}-kubebuilder-${{ steps.get-kubebuilder-version.outputs.version }}
5151

5252
- name: Install Kubebuilder
5353
run: make kubebuilder
5454

55-
- name: Run tests
56-
run: make test
55+
# - name: Run tests
56+
# run: make test
5757

5858
# - name: Figure out if running fork PR
5959
# id: fork

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,15 +184,16 @@ install-configmap-sidecars:
184184
crd-cwnp-for-testing:
185185
curl https://raw.githubusercontent.com/metal-stack/firewall-controller/master/config/crd/bases/metal-stack.io_clusterwidenetworkpolicies.yaml -o external/test/crd-clusterwidenetworkpolicy.yaml
186186

187-
KUBEBUILDER_VERSION:=2.3.2
187+
KUBEBUILDER_VERSION:=2.3.1
188188
kubebuilder:
189189
ifeq (,$(wildcard ~/.kubebuilder/${KUBEBUILDER_VERSION}))
190190
{ \
191191
os=$$(go env GOOS) ;\
192192
arch=$$(go env GOARCH) ;\
193193
curl -L https://go.kubebuilder.io/dl/${KUBEBUILDER_VERSION}/$${os}/$${arch} | tar -xz -C /tmp/ ;\
194194
mv /tmp/kubebuilder_${KUBEBUILDER_VERSION}_$${os}_$${arch}/bin/* ${GOBIN} ;\
195-
mkdir ~/.kubebuilder && touch ~/.kubebuilder/${KUBEBUILDER_VERSION} ;\
195+
mkdir -p ~/.kubebuilder ;\
196+
touch ~/.kubebuilder/${KUBEBUILDER_VERSION} ;\
196197
}
197198
endif
198199

0 commit comments

Comments
 (0)