Logging best practises (#585)

* Update default password hashing algorithm

* Tell the linter that this is not a password

* Sort alphabetically

* Add additional logging params

Author: eberlep

api/v1/postgres_types.go

@@ -85,6 +85,9 @@ const (
 	defaultPostgresParamValueWalKeepSize            = "1GB"
 	defaultPostgresParamValuePGStatStatementsMax    = "500"
 	defaultPostgresParamValuePasswordEncryption     = "scram-sha-256" // nolint
+	defaultPostgresParamValueLogMinErrorStatement   = "WARNING"
+	defaultPostgresParamValueLogErrorVerbosity      = "VERBOSE"
+	defaultPostgresParamValueLogLinePrefix          = "%m [%p]: [%l-1] db=%d,user=%u,app=%a,client=%h "
 
 	// PostgresAutoAssignedIPNamePrefix a prefix to add to the generated random name
 	PostgresAutoAssignedIPNamePrefix = "pgaas-autoassign-"
@@ -959,12 +962,16 @@ func enableAuditLogs(parameters map[string]string) {
 // setDefaultPostgresParams configures default keepalive values
 func setDefaultPostgresParams(parameters map[string]string, version string) {
 	// set default parameters
-	parameters["tcp_keepalives_idle"] = defaultPostgresParamValueTCPKeepAlivesIdle
-	parameters["tcp_keepalives_interval"] = defaultPostgresParamValueTCPKeepAlivesInterval
+	parameters["log_error_verbosity"] = defaultPostgresParamValueLogErrorVerbosity
 	parameters["log_file_mode"] = defaultPostgresParamValueLogFileMode
-
-	parameters["ssl_prefer_server_ciphers"] = defaultPostgresParamValueSSLPreferServerCiphers
+	parameters["log_line_prefix"] = defaultPostgresParamValueLogLinePrefix
+	parameters["log_min_error_statement"] = defaultPostgresParamValueLogMinErrorStatement
+	parameters["password_encryption"] = defaultPostgresParamValuePasswordEncryption
+	parameters["pg_stat_statements.max"] = defaultPostgresParamValuePGStatStatementsMax
 	parameters["ssl_ciphers"] = defaultPostgresParamValueSSLCiphers
+	parameters["ssl_prefer_server_ciphers"] = defaultPostgresParamValueSSLPreferServerCiphers
+	parameters["tcp_keepalives_idle"] = defaultPostgresParamValueTCPKeepAlivesIdle
+	parameters["tcp_keepalives_interval"] = defaultPostgresParamValueTCPKeepAlivesInterval
 
 	// set version specific parameters
 	v, err := strconv.Atoi(version)
@@ -981,10 +988,6 @@ func setDefaultPostgresParams(parameters map[string]string, version string) {
 	} else {
 		parameters["wal_keep_segments"] = defaultPostgresParamValueWalKeepSegments
 	}
-
-	parameters["pg_stat_statements.max"] = defaultPostgresParamValuePGStatStatementsMax
-
-	parameters["password_encryption"] = defaultPostgresParamValuePasswordEncryption
 }
 
 // setPostgresParams add the provided params to the parameter map (but ignore params that are blocked)