[12/N] Fix extra warnings brought by clang-tidy-17 (#140801)

Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch/pytorch#140801
Approved by: https://github.com/Skylion007

Author: cyyever

aten/src/ATen/ExpandUtils.cpp

@@ -35,7 +35,7 @@ Container infer_size_impl(ArrayType a, ArrayType b) {
         ") at non-singleton dimension ", i);
 
       // 1s map to the other size (even 0).
-      expandedSizes[i] = sizeA == 1 ? std::move(sizeB) : std::move(sizeA);
+      expandedSizes[i] = sizeA == 1 ? sizeB : sizeA;
   }
 
   return expandedSizes;

aten/src/ATen/PadNd.h

@@ -11,18 +11,4 @@ enum class padding_mode {
   constant,
 };
 
-static inline c10::string_view padding_mode_string(padding_mode m) {
-  switch (m) {
-    case padding_mode::reflect:
-      return "reflect";
-    case padding_mode::replicate:
-      return "replicate";
-    case padding_mode::circular:
-      return "circular";
-    case padding_mode::constant:
-      return "constant";
-  }
-  TORCH_CHECK(false, "Invalid padding mode (", static_cast<int64_t>(m), ")");
-}
-
 } // namespace at

aten/src/ATen/native/PadNd.cpp

@@ -39,7 +39,6 @@ Tensor constant_pad_nd(const Tensor& self, IntArrayRef pad, const Scalar& value)
              "dimensions of the input. Pad length is ", pad.size(), "while the input has ",
              l_inp, "dimensions.");
 
-    std::vector<int64_t> new_shape;
 
     bool all_pads_non_positive = true;
 
@@ -65,7 +64,9 @@ Tensor constant_pad_nd(const Tensor& self, IntArrayRef pad, const Scalar& value)
     }
 
 
-    for (size_t i = 0; i < (size_t)l_diff; i ++) {
+    std::vector<int64_t> new_shape;
+    new_shape.reserve(l_diff);
+    for (size_t i = 0; i < l_diff; i ++) {
         new_shape.emplace_back(input_sizes[i]);
     }
 
@@ -188,6 +189,21 @@ Tensor _pad_circular_symint(const Tensor &self, c10::SymIntArrayRef padding) {
   return out;
 }
 
+static c10::string_view padding_mode_string(padding_mode m) {
+  switch (m) {
+    case padding_mode::reflect:
+      return "reflect";
+    case padding_mode::replicate:
+      return "replicate";
+    case padding_mode::circular:
+      return "circular";
+    case padding_mode::constant:
+      return "constant";
+  }
+  TORCH_CHECK(false, "Invalid padding mode (", static_cast<int64_t>(m), ")");
+}
+
+
 Tensor _pad_enum_symint(const Tensor &self, c10::SymIntArrayRef pad, int64_t mode_int, std::optional<double> value) {
   const auto input_dim = self.dim();
   TORCH_CHECK(pad.size() % 2 == 0, "Padding length must be divisible by 2");

torch/csrc/distributed/rpc/request_callback_no_python.cpp

@@ -32,6 +32,10 @@ struct DistAutogradContextGuard {
     prevCtxId_ = container.currentContextId();
     container.forceCurrentContextId(ctxId);
   }
+  DistAutogradContextGuard(const DistAutogradContextGuard&) = delete;
+  DistAutogradContextGuard(DistAutogradContextGuard&&) = delete;
+  DistAutogradContextGuard& operator=(const DistAutogradContextGuard&) = delete;
+  DistAutogradContextGuard& operator=(DistAutogradContextGuard&&) = delete;
   ~DistAutogradContextGuard() {
     auto& container = DistAutogradContainer::getInstance();
     container.forceCurrentContextId(prevCtxId_);

torch/csrc/dynamo/cache_entry.h

@@ -59,6 +59,10 @@ typedef struct VISIBILITY_HIDDEN CacheEntry {
   std::string trace_annotation;
 
   CacheEntry(const py::handle& guarded_code, PyObject* backend);
+  CacheEntry(const CacheEntry&) = default;
+  CacheEntry(CacheEntry&&) = default;
+  CacheEntry& operator=(const CacheEntry&) = default;
+  CacheEntry& operator=(CacheEntry&&) = default;
   ~CacheEntry();
 
   // Warning: returns a reference whose lifetime is controlled by C++

torch/csrc/dynamo/compiled_autograd.h

@@ -179,6 +179,7 @@ struct TensorArgs {
   std::vector<uint32_t> input_origins;
 
  private:
+  // NOLINTNEXTLINE(cppcoreguidelines-avoid-const-or-ref-data-members)
   const std::optional<size_t>& active_node_call_idx;
   std::unordered_map<const c10::TensorImpl*, TensorArg> _args;
   // Every TensorArg from this is actually owned by _args (or _undefined) and
@@ -221,6 +222,7 @@ struct LiftedIValueArgs {
   std::vector<uint32_t> args_origins;
 
  private:
+  // NOLINTNEXTLINE(cppcoreguidelines-avoid-const-or-ref-data-members)
   const std::optional<size_t>& active_node_call_idx;
 };
 
@@ -586,11 +588,14 @@ class CompiledNodeArgs {
         _specialization_key(
             // NOLINTNEXTLINE(cppcoreguidelines-no-malloc)
             (uint8_t*)std::malloc(_specialization_key_storage)) {}
+  CompiledNodeArgs(const CompiledNodeArgs&) = delete;
+  CompiledNodeArgs(CompiledNodeArgs&&) = delete;
+  CompiledNodeArgs& operator=(const CompiledNodeArgs&) = delete;
+  CompiledNodeArgs& operator=(CompiledNodeArgs&&) = delete;
   ~CompiledNodeArgs() {
     // NOLINTNEXTLINE(cppcoreguidelines-no-malloc)
     std::free(_specialization_key);
   }
-  CompiledNodeArgs(const CompiledNodeArgs&) = delete;
 
  private:
   template <typename T>
@@ -615,7 +620,7 @@ class CompiledNodeArgs {
 
 struct TraceState {
   TraceState(std::vector<std::optional<c10::SymInt>>&& ss, size_t num_outputs)
-      : sym_sizes(ss), outputs(num_outputs) {}
+      : sym_sizes(std::move(ss)), outputs(num_outputs) {}
 
   void debug_asserts() {
     TORCH_INTERNAL_ASSERT(sym_sizes_index == sym_sizes.size());

torch/csrc/dynamo/extra_state.cpp

@@ -96,7 +96,7 @@ ExtraState* init_and_set_extra_state(PyCodeObject* code) {
   return extra_state;
 }
 
-bool backend_match(PyObject* saved_backend, PyObject* backend) {
+static bool backend_match(PyObject* saved_backend, PyObject* backend) {
   // Pointer equality check for common case
   if (saved_backend != backend) {
     // The Py_TYPE check should not be required but there is a pre-existing