Skip to content

Commit 7633dcb

Browse files
Merge pull request nodegit#1989 from ianhattendorf/fix-python-3.12-node-gyp-incompatibility
Bump node-gyp to 10.0.1
2 parents 6ce1ebf + 0f02eab commit 7633dcb

File tree

3 files changed

+970
-467
lines changed

3 files changed

+970
-467
lines changed

.github/workflows/tests.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
name: "Linux Tests"
1515
strategy:
1616
matrix:
17-
node: [12, 14, 16]
17+
node: [16] # 18+ requires GLIBC 2.28+
1818
runs-on: ubuntu-latest
1919
container: ubuntu:16.04
2020
steps:
@@ -49,10 +49,12 @@ jobs:
4949
git config --global user.name "John Doe"
5050
git config --global user.email johndoe@example.com
5151
52-
- uses: actions/checkout@v2
52+
# v4 requires node 20, which won't run due to GLIBC 2.28+ requirement
53+
- uses: actions/checkout@v3
5354

5455
- name: Use Node.js
55-
uses: actions/setup-node@v2
56+
# v4 requires node 20, which won't run due to GLIBC 2.28+ requirement
57+
uses: actions/setup-node@v3
5658
env:
5759
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
5860
with:
@@ -96,7 +98,7 @@ jobs:
9698
name: "macOS Tests"
9799
strategy:
98100
matrix:
99-
node: [12, 14, 16]
101+
node: [16, 18, 20]
100102
runs-on: macOS-12
101103
# This is mostly the same as the Linux steps, waiting for anchor support
102104
# https://github.com/actions/runner/issues/1182
@@ -112,10 +114,10 @@ jobs:
112114
git config --global user.name "John Doe"
113115
git config --global user.email johndoe@example.com
114116
115-
- uses: actions/checkout@v2
117+
- uses: actions/checkout@v4
116118

117119
- name: Use Node.js
118-
uses: actions/setup-node@v2
120+
uses: actions/setup-node@v4
119121
env:
120122
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
121123
with:
@@ -154,7 +156,7 @@ jobs:
154156
name: Windows Tests
155157
strategy:
156158
matrix:
157-
node: [12, 14, 16]
159+
node: [16, 18, 20]
158160
arch: [x86, x64]
159161
runs-on: windows-2019
160162
steps:
@@ -166,16 +168,16 @@ jobs:
166168
git config --global user.name "John Doe"
167169
git config --global user.email johndoe@example.com
168170
169-
- uses: actions/checkout@v2
171+
- uses: actions/checkout@v4
170172

171173
- name: Use Node.js
172-
uses: implausible/setup-node@feature/expose-architecture-override
174+
uses: actions/setup-node@v4
173175
env:
174176
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
175177
with:
176178
node-version: ${{ matrix.node }}
177179
check-latest: true
178-
node-arch: ${{ matrix.arch }}
180+
architecture: ${{ matrix.arch }}
179181

180182
- name: Install
181183
run: npm install

0 commit comments

Comments
 (0)