Code Quality: Replaced DllImport calls with CsWin32 generations for event object operations #17086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lamparter can you please fill out the template with the steps used to validate these changes? |
|
@0x5bfa requesting your review |
0x5bfa
suggested changes
May 1, 2025
src/Files.App/Program.cs
Outdated
| }); | ||
|
|
||
| _ = CoWaitForMultipleObjects( | ||
| _ = Win32PInvoke.CoWaitForMultipleObjects( |
There was a problem hiding this comment.
Pretty sure you should pin the array.
0x5bfa
suggested changes
May 3, 2025
src/Files.App/App.xaml.cs
Outdated
| Win32PInvoke.CloseHandle(eventHandle); | ||
| unsafe | ||
| { | ||
| fixed (char* fileDialog = "FILEDIALOG") |
src/Files.App/App.xaml.cs
Outdated
| { | ||
| fixed (char* fileDialog = "FILEDIALOG") | ||
| { | ||
| HANDLE eventHandle = PInvoke.CreateEvent(bManualReset: false, bInitialState: false, lpName: fileDialog); |
src/Files.App/Program.cs
Outdated
| public static unsafe void RedirectActivationTo(AppInstance keyInstance, AppActivationArguments args) | ||
| { | ||
| IntPtr eventHandle = CreateEvent(IntPtr.Zero, true, false, null); | ||
| HANDLE eventHandle = PInvoke.CreateEvent(bManualReset: true, bInitialState: false, lpName: null); |
src/Files.App/Program.cs
Outdated
| public static unsafe void OpenFileFromTile(string filePath) | ||
| { | ||
| IntPtr eventHandle = CreateEvent(IntPtr.Zero, true, false, null); | ||
| HANDLE eventHandle = PInvoke.CreateEvent(bManualReset: true, bInitialState: false, lpName: null); |
|
I already did my reviews. |
Lamparter
force-pushed
the
cswin32/events
branch
2 times, most recently
from
52c8594 to
649b6fb
Compare
|
@Lamparter can you please resolve the conflicts? |
Co-authored-by: 0x5BFA <[email protected]> Signed-off-by: Lamparter <[email protected]>
|
I recommend to close this PR, and let us handle this. |
yaira2
force-pushed
the
main
branch
2 times, most recently
from
42c8207 to
4c7493f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues