Code Quality: Improved display of plural strings in Status Center #17300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very good. Did you confirm that each operation state is displaying correctly? This status center is prone to crashing if a string is configured wrong 🙂 |
0x5bfa
reviewed
Jul 24, 2025
0x5bfa
approved these changes
Jul 24, 2025
Tested all except for failure cases. They all seem to work. |
|
@SilverGreen93 thank you! |
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update Status Center strings to include plural forms for
item(s)andfont(s).Use the
GetLocalizedFormatResourceinstead ofGetLocalizedResourceand move theheaderStringandsubHeaderStringinitialization to each corresponding case.Also removed the redundant
if (headerString is not null)checks, as the string cannot be null at that point.Resolved / Related Issues
Steps used to test these changes
Tested the changed strings in file operations.