Feature: Middle click breadcrumb parent opens folder in new tab (fix #17378) #17492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les-community#17378)feat(ui): middle click Omnibar parent opens folder in new tab (fix files-community#17378)feat(ui): Add middle-click handler for BreadcrumbBarItemfeat(ui): Add middle-click handler for BreadcrumbBarItemfeat(ui): Add middle-click handler for BreadcrumbBarItemUpdate BreadcrumbBarItem.Events.cs - Add PointerPressed event handler to detect middle mouse button clicks - Include Microsoft.UI.Input using statement for pointer properties - Call OnItemMiddleClicked() method when middle button is pressed - Part of implementation for opening parent folder in new tab on middle-click (issue files-community#17378) Signed-off-by: DHANUSH RAJA <[email protected]>
…licked event to BreadcrumbBarfeat(ui): add ItemMiddleClicked event to BreadcrumbBarUpdate BreadcrumbBar.cs Signed-off-by: DHANUSH RAJA <[email protected]>
Signed-off-by: DHANUSH RAJA <[email protected]>
…arItem.cs Signed-off-by: DHANUSH RAJA <[email protected]>
…les-community#17378)feat(ui): middle click Omnibar parent opens folder in new tab (fix files-community#17378)Update NavigationToolbar.xaml.cs Signed-off-by: DHANUSH RAJA <[email protected]>
Member
|
This is already being worked on in #17476 |
Member
|
@DHANUSHRAJA22 thank you for your PR. As Josh mentioned, someone already started a similar PR. Can you please take a look at #17476 and offer your feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Description
This PR implements the ability for users to middle-click on parent folder breadcrumbs in the navigation toolbar to open those folders in new tabs. When a user middle-clicks on any breadcrumb item except the current folder (the last item), it will open that parent folder in a new tab.
Changes Made:
ItemMiddleClickedevent toBreadcrumbBarcontrolBreadcrumbBarItemMiddleClickedEventArgsclass for event argumentsBreadcrumbBarItemto detect middle mouse button clicksBreadcrumbBar_ItemMiddleClickedhandler inNavigationToolbar.xaml.csthat:ViewModel.PathComponents[args.Index].PathNavigationHelpers.AddNewTabByPathAsync(typeof(ShellPanesPage), path, false)to open the folder in a new tabSteps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
-->
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.