Return empty string when we have no response headers; fix phoboslab#533

phoboslab · phoboslab · commit fa035d05379b · 2015-08-02T20:26:57.000+02:00
diff --git a/Source/Ejecta/EJUtils/EJBindingHttpRequest.m b/Source/Ejecta/EJUtils/EJBindingHttpRequest.m
@@ -184,9 +184,12 @@ - (void)connection:(NSURLConnection *)connection didReceiveData:(NSData *)data {
 }
 
 EJ_BIND_FUNCTION(getAllResponseHeaders, ctx, argc, argv) {
-	if( !response || ![response isKindOfClass:[NSHTTPURLResponse class]] ) {
+	if( !response ) {
 		return NULL;
 	}
+	if( ![response isKindOfClass:[NSHTTPURLResponse class]] ) {
+		NSStringToJSValue(ctx, @"");
+	}
 	
 	NSHTTPURLResponse *urlResponse = (NSHTTPURLResponse *)response;
 	NSMutableString *headers = [NSMutableString string];

Original file line number	Diff line number	Diff line change
`@@ -184,9 +184,12 @@ - (void)connection:(NSURLConnection )connection didReceiveData:(NSData )data {`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`EJ_BIND_FUNCTION(getAllResponseHeaders, ctx, argc, argv) {`
`187`		`- if( !response \|\| ![response isKindOfClass:[NSHTTPURLResponse class]] ) {`
	`187`	`+ if( !response ) {`
`188`	`188`	`return NULL;`
`189`	`189`	`}`
	`190`	`+ if( ![response isKindOfClass:[NSHTTPURLResponse class]] ) {`
	`191`	`+ NSStringToJSValue(ctx, @"");`
	`192`	`+ }`
`190`	`193`
`191`	`194`	`NSHTTPURLResponse urlResponse = (NSHTTPURLResponse )response;`
`192`	`195`	`NSMutableString *headers = [NSMutableString string];`