Skip to content

Commit f4494c4

Browse files
authored
Merge pull request #872 from firebase/version-2.3.0-release
Version 2.3.0
2 parents 49ca5e1 + 9d4efee commit f4494c4

File tree

99 files changed

+667
-383
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

99 files changed

+667
-383
lines changed

README.md

Lines changed: 5 additions & 4 deletions

app/build.gradle

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ android {
1111
targetSdkVersion targetSdk
1212
versionCode 1
1313
versionName "1.0"
14+
15+
vectorDrawables.useSupportLibrary = true
1416
}
1517

1618
buildTypes {
@@ -42,15 +44,15 @@ dependencies {
4244
compile "com.google.firebase:firebase-database:$firebaseVersion"
4345
compile "com.google.firebase:firebase-storage:$firebaseVersion"
4446

45-
compile('com.facebook.android:facebook-android-sdk:4.23.0')
47+
compile('com.facebook.android:facebook-android-sdk:4.25.0')
4648
compile("com.twitter.sdk.android:twitter-core:3.0.0@aar") { transitive = true }
4749

4850
// The following dependencies are not required to use the Firebase UI library.
4951
// They are used to make some aspects of the demo app implementation simpler for
5052
// demonstrative purposes, and you may find them useful in your own apps; YMMV.
51-
compile 'pub.devrel:easypermissions:0.4.2'
52-
compile 'com.jakewharton:butterknife:8.5.1'
53-
annotationProcessor 'com.jakewharton:butterknife-compiler:8.5.1'
53+
compile 'pub.devrel:easypermissions:0.4.3'
54+
compile 'com.jakewharton:butterknife:8.7.0'
55+
annotationProcessor 'com.jakewharton:butterknife-compiler:8.7.0'
5456
debugCompile 'com.squareup.leakcanary:leakcanary-android:1.5'
5557
releaseCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.5.1'
5658
testCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.5.1'

app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
android:allowBackup="true"
1414
android:fullBackupContent="true"
1515
android:icon="@mipmap/ic_launcher"
16+
android:roundIcon="@mipmap/ic_launcher_round"
1617
android:supportsRtl="true"
1718
android:theme="@style/AppTheme"
1819
tools:ignore="GoogleAppIndexingWarning">

app/src/main/java/com/firebase/uidemo/auth/AuthUiActivity.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import com.firebase.ui.auth.AuthUI.IdpConfig;
3636
import com.firebase.ui.auth.ErrorCodes;
3737
import com.firebase.ui.auth.IdpResponse;
38-
import com.firebase.ui.auth.ResultCodes;
3938
import com.firebase.uidemo.R;
4039
import com.google.android.gms.common.Scopes;
4140
import com.google.firebase.auth.FirebaseAuth;
@@ -54,6 +53,7 @@ public class AuthUiActivity extends AppCompatActivity {
5453
private static final String FIREBASE_TOS_URL = "https://firebase.google.com/terms/";
5554
private static final String GOOGLE_PRIVACY_POLICY_URL = "https://www.google.com/policies/privacy/";
5655
private static final String FIREBASE_PRIVACY_POLICY_URL = "https://firebase.google.com/terms/analytics/#7_privacy";
56+
5757
private static final int RC_SIGN_IN = 100;
5858

5959
@BindView(R.id.default_theme)
@@ -138,9 +138,7 @@ public class AuthUiActivity extends AppCompatActivity {
138138
CheckBox mGoogleScopeYoutubeData;
139139

140140
public static Intent createIntent(Context context) {
141-
Intent in = new Intent();
142-
in.setClass(context, AuthUiActivity.class);
143-
return in;
141+
return new Intent(context, AuthUiActivity.class);
144142
}
145143

146144
@Override
@@ -229,7 +227,7 @@ private void handleSignInResponse(int resultCode, Intent data) {
229227
IdpResponse response = IdpResponse.fromResultIntent(data);
230228

231229
// Successfully signed in
232-
if (resultCode == ResultCodes.OK) {
230+
if (resultCode == RESULT_OK) {
233231
startSignedInActivity(response);
234232
finish();
235233
return;
@@ -307,7 +305,7 @@ private int getSelectedLogo() {
307305
if (mFirebaseLogo.isChecked()) {
308306
return R.drawable.firebase_auth_120dp;
309307
} else if (mGoogleLogo.isChecked()) {
310-
return R.drawable.logo_googleg_color_144dp;
308+
return R.drawable.ic_googleg_color_144dp;
311309
}
312310
return AuthUI.NO_LOGO;
313311
}

app/src/main/java/com/firebase/uidemo/auth/SignedInActivity.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,7 @@ public void onComplete(@NonNull Task<Void> task) {
133133

134134
@OnClick(R.id.delete_account)
135135
public void deleteAccountClicked() {
136-
137-
AlertDialog dialog = new AlertDialog.Builder(this)
136+
new AlertDialog.Builder(this)
138137
.setMessage("Are you sure you want to delete this account?")
139138
.setPositiveButton("Yes, nuke it!", new DialogInterface.OnClickListener() {
140139
@Override
@@ -143,9 +142,7 @@ public void onClick(DialogInterface dialogInterface, int i) {
143142
}
144143
})
145144
.setNegativeButton("No", null)
146-
.create();
147-
148-
dialog.show();
145+
.show();
149146
}
150147

151148
private void deleteAccount() {
-894 Bytes
Binary file not shown.
Binary file not shown.
-568 Bytes
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)