gossip: handle identity change in sampler state

Author: ravyu-jump

src/flamenco/gossip/crds/fd_crds.c

@@ -1100,7 +1100,7 @@ fd_crds_insert( fd_crds_t *                         crds,
 
     crds_contact_info_evict_dlist_ele_push_tail( crds->contact_info.evict_dlist, candidate, crds->pool );
 
-    if( FD_LIKELY( !is_from_me ) ){
+    if( FD_LIKELY( !is_from_me ) ) {
       crds_contact_info_fresh_list_ele_push_tail( crds->contact_info.fresh_dlist, candidate, crds->pool );
       candidate->contact_info.fresh_dlist.in_list = 1;
     } else {
@@ -1225,6 +1225,21 @@ fd_crds_peer_sample( fd_crds_t const * crds,
   return crds_contact_info_pool_ele( crds->contact_info.pool, idx )->contact_info;
 }
 
+void
+fd_crds_handle_identity_change( fd_crds_t *   crds,
+                                uchar const * new_identity_pubkey ) {
+  fd_crds_key_t old_key[1];
+  make_contact_info_key( new_identity_pubkey, old_key );
+  fd_crds_entry_t * new_ci = lookup_map_ele_query( crds->lookup_map, old_key, NULL, crds->pool );
+  if( FD_UNLIKELY( !new_ci ) ) return;
+
+  ulong new_idx = crds_contact_info_pool_idx( crds->contact_info.pool, new_ci->contact_info.ci );
+
+  wpeer_sampler_upd( crds->crds_sampler, 0UL, new_idx );
+  crds->change_fn( crds->change_fn_ctx, new_idx, new_ci->stake, FD_CRDS_CONTACT_INFO_CHANGE_IDENTITY_CHANGED, NULL, 0L );
+
+}
+
 struct fd_crds_mask_iter_private {
   ulong idx;
   ulong end_hash;

src/flamenco/gossip/crds/fd_crds.h

@@ -34,6 +34,7 @@ typedef struct fd_crds_mask_iter_private fd_crds_mask_iter_t;
 #define FD_CRDS_CONTACT_INFO_CHANGE_TYPE_NEW            (0)
 #define FD_CRDS_CONTACT_INFO_CHANGE_TYPE_REMOVED        (1)
 #define FD_CRDS_CONTACT_INFO_CHANGE_TYPE_STAKE_CHANGED  (2)
+#define FD_CRDS_CONTACT_INFO_CHANGE_IDENTITY_CHANGED    (3)
 
 typedef void (*fd_crds_ci_change_fn)( void *               ctx,
                                       ulong                crds_pool_idx,
@@ -308,6 +309,10 @@ fd_contact_info_t const *
 fd_crds_peer_sample( fd_crds_t const * crds,
                      fd_rng_t *        rng );
 
+void
+fd_crds_handle_identity_change( fd_crds_t *   crds,
+                                uchar const * new_identity_pubkey );
+
 /* fd_crds_mask_iter_{init,next,done,entry} provide an API to
    iterate over the CRDS values in the table that whose hashes match
    a given mask. In the Gossip CRDS filter, the mask is applied on

src/flamenco/gossip/fd_active_set.c

@@ -285,7 +285,7 @@ fd_active_set_rotate( fd_active_set_t *            active_set,
     last_hit_idx_remove( active_set->last_hit, replace_idx, active_set->entry_pool );
 
     /* Replaced peer needs to be reinserted into bucket's sampler */
-    peer_meta_t *      e     = &active_set->peer_metas[ crds_idx ];
+    peer_meta_t *          e     = &active_set->peer_metas[ crds_idx ];
     ulong                  score = peer_bucket_score( e->stake, bucket_idx );
     e->bucket_idx[ bucket_idx ]  = BUCKET_ENTRY_IDX_SENTINEL;
     wpeer_sampler_upd( bucket->sampler, score, crds_idx );

src/flamenco/gossip/fd_gossip.c

@@ -371,6 +371,16 @@ ci_change( void *              _ctx,
       }
       break;
     case FD_CRDS_CONTACT_INFO_CHANGE_TYPE_STAKE_CHANGED: fd_active_set_peer_update_stake( ctx->active_set, crds_pool_idx, stake ); break;
+    case FD_CRDS_CONTACT_INFO_CHANGE_IDENTITY_CHANGED:
+      {
+        FD_TEST( stem==NULL );
+        fd_active_set_push_state_t states_to_reset[ FD_ACTIVE_SET_STAKE_BUCKETS ];
+        ulong state_cnt = fd_active_set_peer_remove( ctx->active_set, crds_pool_idx, states_to_reset );
+        for( ulong i=0UL; i<state_cnt; i++ ) {
+          fd_gossip_txbuild_init( states_to_reset[i].txbuild, FD_GOSSIP_MESSAGE_PUSH );
+        }
+      }
+      break;
     default: FD_LOG_ERR(( "Unknown change type %d", change_type )); return;
   }
 }
@@ -412,6 +422,11 @@ void
 fd_gossip_set_my_contact_info( fd_gossip_t *             gossip,
                                fd_contact_info_t const * contact_info,
                                long                      now ) {
+  if( FD_UNLIKELY( memcmp( gossip->identity_pubkey, contact_info->pubkey.uc, 32UL ) ) ){
+    FD_LOG_WARNING(( "Changing identity pubkey" ));
+    fd_crds_handle_identity_change( gossip->crds, contact_info->pubkey.uc );
+
+  }
   fd_memcpy( gossip->identity_pubkey, contact_info->pubkey.uc, 32UL );
 
   *gossip->my_contact_info.ci = *contact_info;