Postgres use of PGHOSTADDR panics go lib/pg

[stahnma]

The use of PGHOSTADDR panics go postgres connections. I find myself having to unset it.

os.Unsetenv("PGHOSTADDR")

Are there other patterns that could be used?

[devusb]

it seems like having PGHOST set to the path containing the socket file is enough for both Python applications (e.g. pgcli or and other psycopg2 users) and Go applications using lib/pq to not complain, but still be able to connect to the database started by flox services start transparently, as it seems they both will look at PGHOST to find the location of the socket.

specifically, I removed PGHOSTADDR and PGPORT completely, and changed the pg_ctl line used to init to

pg_ctl -D "$PGDATA" -w start -o "-c unix_socket_directories=$PGHOST" > /dev/null

and the start command to

postgres.command = "postgres -D $PGDATA -c unix_socket_directories=$PGHOST"

and I was able to get something that seemed to work transparently without having to unset any variables.

is there a reason why we were using PGHOSTADDR and PGPORT in the first place that I missed, or would removing them and just offering the socket by default be enough? if so, I can open a PR to make these changes.

[devusb]

oh, I just noticed #712 🙃