Rework the integration test timeout logic #9322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reduction in test times here is fantastic! Nice work! |
| }); | ||
| testWidgets( | ||
| 'connect to app and switch tabs', | ||
| timeout: const Timeout(Duration(minutes: 2)), |
There was a problem hiding this comment.
just for consistency, can we add consts shortTimeout, mediumTimeout and longTimeout and put them in integration_test/test_infra/_utils.dart?
kenzieschmoll
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 8-minute timeout was being applied to every test, even successful test results.
In this code:
While this does return the first future that completes, the process will still wait for any other futures to complete, including an 8-minute delayed Future.
Additionally, each
testWidgetscall has a timeout, which is either infinite or 10 minutes (according to the docs). Either way, the timeout is longer than the 8-minute timeout, so we need to reduce these too. I chose some timeouts somewhat at random, but I believe conservatively, at 2, 3, or 4 minutes.This change brings the following GitHub Action times down as follows: