Skip to content

Commit 4351801

Browse files
authored
[verifier] enable COMPATIBILITY_WARNINGS and MISSING_DEPENDENCIES (#8362)
Enable a few warnings that are currently clean. See: #8361 --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent 0979e12 commit 4351801

File tree

1 file changed

+19
-17
lines changed

1 file changed

+19
-17
lines changed

build.gradle.kts

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
*/
66

77
import okhttp3.internal.immutableListOf
8+
import org.gradle.api.tasks.testing.logging.TestExceptionFormat
89
import org.jetbrains.intellij.platform.gradle.IntelliJPlatformType
910
import org.jetbrains.intellij.platform.gradle.TestFrameworkType
1011
import org.jetbrains.intellij.platform.gradle.models.ProductRelease
1112
import org.jetbrains.intellij.platform.gradle.tasks.VerifyPluginTask
1213
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
1314
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
14-
import org.gradle.api.tasks.testing.logging.TestExceptionFormat
1515

1616
// Specify UTF-8 for all compilations so we avoid Windows-1252.
1717
allprojects {
@@ -106,19 +106,21 @@ dependencies {
106106
// Plugin dependency documentation:
107107
// https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-dependencies-extension.html#plugins
108108
// https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html#project-setup
109-
bundledPlugins(immutableListOf(
110-
"com.google.tools.ij.aiplugin",
111-
"com.intellij.java",
112-
"com.intellij.properties",
113-
"JUnit",
114-
"Git4Idea",
115-
"org.jetbrains.kotlin",
116-
"org.jetbrains.plugins.gradle",
117-
"org.jetbrains.plugins.yaml",
118-
"org.intellij.intelliLang",
119-
"org.jetbrains.android",
120-
"com.android.tools.idea.smali"
121-
))
109+
bundledPlugins(
110+
immutableListOf(
111+
"com.google.tools.ij.aiplugin",
112+
"com.intellij.java",
113+
"com.intellij.properties",
114+
"JUnit",
115+
"Git4Idea",
116+
"org.jetbrains.kotlin",
117+
"org.jetbrains.plugins.gradle",
118+
"org.jetbrains.plugins.yaml",
119+
"org.intellij.intelliLang",
120+
"org.jetbrains.android",
121+
"com.android.tools.idea.smali"
122+
)
123+
)
122124
plugin("Dart:$dartPluginVersion")
123125

124126
if (sinceBuildInput == "243" || sinceBuildInput == "251") {
@@ -164,8 +166,8 @@ intellijPlatform {
164166
cliPath = file("./third_party/lib/verifier-cli-1.388-all.jar")
165167
failureLevel = listOf(
166168
// TODO(team) Ideally all of the following FailureLevels should be enabled:
167-
// TODO(team) Create a tracking issue for each of the following validations
168-
// VerifyPluginTask.FailureLevel.COMPATIBILITY_WARNINGS,
169+
// https://github.com/flutter/flutter-intellij/issues/8361
170+
VerifyPluginTask.FailureLevel.COMPATIBILITY_WARNINGS,
169171
VerifyPluginTask.FailureLevel.COMPATIBILITY_PROBLEMS,
170172
// VerifyPluginTask.FailureLevel.DEPRECATED_API_USAGES, // https://github.com/flutter/flutter-intellij/issues/7718
171173
// VerifyPluginTask.FailureLevel.SCHEDULED_FOR_REMOVAL_API_USAGES,
@@ -174,7 +176,7 @@ intellijPlatform {
174176
// VerifyPluginTask.FailureLevel.OVERRIDE_ONLY_API_USAGES,
175177
VerifyPluginTask.FailureLevel.NON_EXTENDABLE_API_USAGES,
176178
VerifyPluginTask.FailureLevel.PLUGIN_STRUCTURE_WARNINGS,
177-
// VerifyPluginTask.FailureLevel.MISSING_DEPENDENCIES,
179+
VerifyPluginTask.FailureLevel.MISSING_DEPENDENCIES,
178180
VerifyPluginTask.FailureLevel.INVALID_PLUGIN,
179181
// VerifyPluginTask.FailureLevel.NOT_DYNAMIC,
180182
)

0 commit comments

Comments
 (0)