Skip to content

Commit dcfece3

Browse files
authored
[logging] Use PluginLogger for bazel doctor and analytics (#8373)
I'm just looking through the code and checking that paths aren't going to be logged. Bazel path for flutter doctor probably is used very little (if at all) and analytics isn't used at all (will probably be moved to dart plugin?). Related to #8369
1 parent ed9d34d commit dcfece3

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/io/flutter/actions/FlutterDoctorAction.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import io.flutter.FlutterUtils;
1717
import io.flutter.bazel.Workspace;
1818
import io.flutter.console.FlutterConsoles;
19+
import io.flutter.logging.PluginLogger;
1920
import io.flutter.pub.PubRoot;
2021
import io.flutter.sdk.FlutterSdk;
2122
import org.jetbrains.annotations.NotNull;
@@ -25,7 +26,7 @@
2526

2627
public class FlutterDoctorAction extends FlutterSdkAction {
2728

28-
private static final @NotNull Logger LOG = Logger.getInstance(FlutterDoctorAction.class);
29+
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterDoctorAction.class);
2930

3031
public void startCommand(@NotNull Project project, @NotNull FlutterSdk sdk, @Nullable PubRoot root) {
3132
sdk.flutterDoctor().startInConsole(project);

src/io/flutter/analytics/UnifiedAnalytics.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import com.jetbrains.lang.dart.ide.toolingDaemon.DartToolingDaemonService;
1818
import de.roderick.weberknecht.WebSocketException;
1919
import io.flutter.dart.DtdUtils;
20+
import io.flutter.logging.PluginLogger;
2021
import io.flutter.sdk.FlutterSdkUtil;
2122
import io.flutter.utils.OpenApiUtils;
2223
import org.jetbrains.annotations.NotNull;
@@ -28,7 +29,7 @@
2829
* Facilitates sending information to unified analytics.
2930
*/
3031
public class UnifiedAnalytics {
31-
private static final @NotNull Logger LOG = Logger.getInstance(UnifiedAnalytics.class);
32+
private static final @NotNull Logger LOG = PluginLogger.createLogger(UnifiedAnalytics.class);
3233

3334
@Nullable Boolean enabled = null;
3435
final Project project;

0 commit comments

Comments
 (0)