sourcev1: align CRD validation with v1beta2

Author: kthurman59

api/v1/gitrepository_types.go

@@ -96,6 +96,7 @@ type GitRepositorySpec struct {
 	// Provider used for authentication, can be 'azure', 'github', 'generic'.
 	// When not specified, defaults to 'generic'.
 	// +kubebuilder:validation:Enum=generic;azure;github
+	// +kubebuilder:default:=generic
 	// +optional
 	Provider string `json:"provider,omitempty"`
 

api/v1/helmchart_types.go

@@ -28,6 +28,7 @@ import (
 const HelmChartKind = "HelmChart"
 
 // HelmChartSpec specifies the desired state of a Helm chart.
+// +kubebuilder:validation:XValidation:rule="!has(self.verify) || self.sourceRef.kind == 'HelmRepository'",message="spec.verify is only supported when spec.sourceRef.kind is 'HelmRepository'"
 type HelmChartSpec struct {
 	// Chart is the name or path the Helm chart is available at in the
 	// SourceRef.

api/v1/helmrepository_types.go

@@ -100,6 +100,7 @@ type HelmRepositorySpec struct {
 	// and for remote OCI Repository operations like pulling for an OCI helm
 	// chart by the associated HelmChart.
 	// Its default value is 60s.
+	// +kubebuilder:default="60s"
 	// +kubebuilder:validation:Type=string
 	// +kubebuilder:validation:Pattern="^([0-9]+(\\.[0-9]+)?(ms|s|m))+$"
 	// +optional

config/crd/bases/source.toolkit.fluxcd.io_gitrepositories.yaml

@@ -104,6 +104,7 @@ spec:
                 pattern: ^([0-9]+(\.[0-9]+)?(ms|s|m|h))+$
                 type: string
               provider:
+                default: generic
                 description: |-
                   Provider used for authentication, can be 'azure', 'github', 'generic'.
                   When not specified, defaults to 'generic'.

config/crd/bases/source.toolkit.fluxcd.io_helmcharts.yaml

@@ -198,6 +198,9 @@ spec:
             - interval
             - sourceRef
             type: object
+            x-kubernetes-validations:
+            - message: spec.verify is only supported when spec.sourceRef.kind is 'HelmRepository'
+              rule: '!has(self.verify) || self.sourceRef.kind == ''HelmRepository'''
           status:
             default:
               observedGeneration: -1

config/crd/bases/source.toolkit.fluxcd.io_helmrepositories.yaml

@@ -162,6 +162,7 @@ spec:
                   HelmRepository.
                 type: boolean
               timeout:
+                default: 60s
                 description: |-
                   Timeout is used for the index fetch operation for an HTTPS helm repository,
                   and for remote OCI Repository operations like pulling for an OCI helm