Skip to content

Commit a2a6e7d

Browse files
fix: removed unnecessary comments
1 parent 3277d57 commit a2a6e7d

File tree

7 files changed

+14
-26
lines changed

7 files changed

+14
-26
lines changed

lib/bademagic_module/models/screen_size.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ class ScreenSize {
1919
int get hashCode => width.hashCode ^ height.hashCode ^ name.hashCode;
2020
}
2121

22-
// Example size list
2322
const List<ScreenSize> supportedScreenSizes = [
2423
ScreenSize(width: 44, height: 11, name: "Small (44x11)"),
2524
ScreenSize(width: 64, height: 16, name: "Medium (64x16)"),

lib/main.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class MyApp extends StatelessWidget {
5252
'/aboutUs': (context) => const AboutUsScreen(),
5353
'/settings': (context) => const SettingsScreen(),
5454
'/drawBadge': (context) => DrawBadge(
55-
selectedSize: supportedScreenSizes[0], // Default size
55+
selectedSize: supportedScreenSizes[0],
5656
),
5757
},
5858
);

lib/providers/animation_badge_provider.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ class AnimationBadgeProvider extends ChangeNotifier {
4646

4747
List<List<bool>> _paintGrid = [];
4848
List<List<bool>> _newGrid = [];
49-
// ignore: prefer_final_fields
50-
List<List<List<bool>>> _frames = [];
49+
final List<List<List<bool>>> _frames = [];
5150
int _currentFrame = 0;
5251

5352
BadgeAnimation _currentAnimation = LeftAnimation();

lib/view/draw_badge_screen.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ class DrawBadge extends StatefulWidget {
1515
final bool? isSavedCard;
1616
final bool? isSavedClipart;
1717
final List<List<int>>? badgeGrid;
18-
final ScreenSize selectedSize; // <-- Add this parameter!
18+
final ScreenSize selectedSize;
1919

2020
const DrawBadge({
2121
super.key,
2222
this.filename,
2323
this.isSavedCard = false,
2424
this.isSavedClipart = false,
2525
this.badgeGrid,
26-
required this.selectedSize, // <-- Mark as required
26+
required this.selectedSize,
2727
});
2828

2929
@override
@@ -37,7 +37,6 @@ class _DrawBadgeState extends State<DrawBadge> {
3737
void initState() {
3838
super.initState();
3939
drawToggle = DrawBadgeProvider();
40-
// Initialize grid with selected size
4140
drawToggle.initGridWithSize(widget.selectedSize);
4241
WidgetsBinding.instance.addPostFrameCallback((_) {
4342
_setLandscapeOrientation();
@@ -135,8 +134,7 @@ class _DrawBadgeState extends State<DrawBadge> {
135134
badgeGrid: widget.badgeGrid
136135
?.map((e) => e.map((e) => e == 1).toList())
137136
.toList(),
138-
selectedSize:
139-
widget.selectedSize, // <-- Pass the size here!
137+
selectedSize: widget.selectedSize,
140138
),
141139
],
142140
),

lib/view/homescreen.dart

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class _HomeScreenState extends State<HomeScreen>
5050
final TextEditingController inlineimagecontroller =
5151
GetIt.instance.get<InlineImageProvider>().getController();
5252
bool isDialInteracting = false;
53-
String _cachedText = ''; // <-- NEW: to cache text on pause
53+
String _cachedText = '';
5454
late ScreenSize _selectedSize;
5555

5656
@override
@@ -65,7 +65,7 @@ class _HomeScreenState extends State<HomeScreen>
6565
_startImageCaching();
6666
speedDialProvider = SpeedDialProvider(animationProvider);
6767
_tabController = TabController(length: 3, vsync: this);
68-
_selectedSize = supportedScreenSizes.first; // default value
68+
_selectedSize = supportedScreenSizes.first;
6969
}
7070

7171
@override
@@ -203,11 +203,7 @@ class _HomeScreenState extends State<HomeScreen>
203203
if (newSize != null) {
204204
setState(() {
205205
_selectedSize = newSize;
206-
207-
// Re-init all providers/grids related to size
208206
animationProvider.initGrids(_selectedSize);
209-
// If using draw badge somewhere: drawProvider.initGridWithSize(_selectedSize);
210-
211207
animationProvider.badgeAnimation(
212208
inlineImageProvider.getController().text,
213209
Converters(),
@@ -370,7 +366,7 @@ class _HomeScreenState extends State<HomeScreen>
370366
null,
371367
false,
372368
_selectedSize.height,
373-
_selectedSize.width, // <-- pass badge height
369+
_selectedSize.width,
374370
);
375371
},
376372
child: Container(

lib/view/save_badge_screen.dart

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ class _SaveBadgeScreenState extends State<SaveBadgeScreen> {
3939
@override
4040
void initState() {
4141
_setOrientation();
42-
_selectedSize = supportedScreenSizes.first; // 👈 Default screen size
43-
animationBadgeProvider.initGrids(_selectedSize); // 👈 Initialize grid
42+
_selectedSize = supportedScreenSizes.first;
43+
animationBadgeProvider.initGrids(_selectedSize);
4444

4545
super.initState();
4646
}
@@ -131,7 +131,6 @@ class _SaveBadgeScreenState extends State<SaveBadgeScreen> {
131131
children: [
132132
Column(
133133
children: [
134-
// Allow user to select screen size for preview/transfer
135134
Padding(
136135
padding: EdgeInsets.symmetric(
137136
horizontal: 15.w, vertical: 10.h),
@@ -211,7 +210,6 @@ class _SaveBadgeScreenState extends State<SaveBadgeScreen> {
211210
badgeData['messages'][0]);
212211
badgeDataList.add(message);
213212
}
214-
//add empty message object in the badgeList such that total count becomes 8
215213
while (badgeDataList.length < 8) {
216214
badgeDataList.add(Message(text: []));
217215
}
@@ -226,9 +224,7 @@ class _SaveBadgeScreenState extends State<SaveBadgeScreen> {
226224
data.toJson(),
227225
true,
228226
_selectedSize.height,
229-
_selectedSize
230-
.width // <-- pass badge height
231-
);
227+
_selectedSize.width);
232228
}
233229
: null,
234230
style: ElevatedButton.styleFrom(

lib/view/saved_clipart.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ class SavedClipart extends StatefulWidget {
2121
class _SavedClipartState extends State<SavedClipart> {
2222
InlineImageProvider imageprovider = GetIt.instance<InlineImageProvider>();
2323
FileHelper file = FileHelper();
24-
late final ScreenSize selectedSize; // <-- Add this parameter!
24+
late final ScreenSize selectedSize;
2525

2626
@override
2727
void initState() {
2828
_setOrientation();
2929
super.initState();
30-
selectedSize = supportedScreenSizes.first;
30+
selectedSize = supportedScreenSizes.first;
3131
}
3232

3333
void _setOrientation() {
@@ -86,7 +86,7 @@ class _SavedClipartState extends State<SavedClipart> {
8686
imageprovider.generateImageCache();
8787
},
8888
selectedSize: selectedSize,
89-
), // Use the separate ListView widget here
89+
),
9090
);
9191
}
9292
}

0 commit comments

Comments
 (0)