-
Notifications
You must be signed in to change notification settings - Fork 815
fix: fix data acquisition from TSL2561 luminosity sensor #2790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideRefactor the TSL2561 sensor driver to scan multiple I2C addresses, clean up constants, and correct data reads, and update the sensor list UI to use integer addresses and show IDs in hex. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/16365621966/artifacts/3561661927 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcnause Thank you very much for this !
When the sensor was probed a second time after being active, the expected value was not returned and the app did not recognize the sensor.
Fixes #2783
Changes
I think there are still a few things to fix in the screen, but data acquisition works, which was the scope of the issue.
Screenshots / Recordings
Screen_recording_20250717_191534.mp4
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Summary by Sourcery
Add support for detecting TSL2561 sensors at multiple I2C addresses and correct raw luminosity reads, while updating the sensor screen to display addresses in hex
New Features:
Bug Fixes:
Enhancements: