Skip to content

Commit d83dddc

Browse files
authored
Remove pythonPath option given to python-shell module (#656)
This fixes the bug where PSLab Desktop on Windows would not connect to the board unless python3 was linked to python with `mklink python3.exe python.exe` in the Python installation folder. See also https://github.com/extrabacon/python-shell/blob/f3b64d3307d8dc15eb9c071d8aa774c1e7d5b2d7/index.ts#L94
1 parent bc4e949 commit d83dddc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

background_tasks/linker.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
const log = require('electron-log');
88

99
const bridgePath = getScriptPath('bridge.py');
10-
const pyshell = new PythonShell(bridgePath, { pythonPath: 'python3' });
10+
const pyshell = new PythonShell(bridgePath);
1111
log.info('Python spawned:', pyshell && pyshell.command);
1212

1313
loadBalancer.job(

background_tasks/playback.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// For distribution, we bundle everything into an asar archive.
1010
const bridgePath = getScriptPath('bridge.py');
11-
const pyshell = new PythonShell(bridgePath, { pythonPath: 'python3' });
11+
const pyshell = new PythonShell(bridgePath);
1212
log.info('Python spawned:', pyshell && pyshell.command);
1313

1414
loadBalancer.job(

0 commit comments

Comments
 (0)