-
Notifications
You must be signed in to change notification settings - Fork 93
fix: resolve Weblate integration issues with translation key inconsistencies #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding a CI check or script to automatically validate that all locale files match the reference keys to prevent future merge conflicts.
- It would help to sort the keys alphabetically in each messages.json so that diffs are cleaner and easier to review.
- You may want to have a native Portuguese speaker review the newly added translations to ensure accuracy and context.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a CI check or script to automatically validate that all locale files match the reference keys to prevent future merge conflicts.
- It would help to sort the keys alphabetically in each messages.json so that diffs are cleaner and easier to review.
- You may want to have a native Portuguese speaker review the newly added translations to ensure accuracy and context.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@vedansh-5 Please review this PR and let me know if you want any changes. Thanks ! |
@Anshumancanrock Please add screenshots of the translation in any of the languages of all the possible screens. |
@Anshumancanrock Please add screenshots for the correct translation in any of the one languages. |
Sir @vedansh-5, here’s the screenshot in Portuguese after fix. Apologies for the late response. ![]() |
@hpdang lgtm! Thanks @Anshumancanrock |
📌 Fixes
Fixes #240
📝 Summary of Changes
homeButtonTitle
key from 11 non-English locale files (de, es, fr, hi, id, ja, pt_BR, ru, vi, zh_CN, zh_TW)📸 Screenshots / Demo (if UI-related)
✅ Checklist
👀 Reviewer Notes
Summary by Sourcery
Fix translation key inconsistencies and align all locale files with the English reference to resolve Weblate integration issues
Bug Fixes:
Enhancements: