refactor: move to new codesize lint group

Author: 0xrusowsky

crates/config/src/lint.rs

@@ -45,6 +45,7 @@ pub enum Severity {
     Low,
     Info,
     Gas,
+    CodeSize,
 }
 
 impl Severity {
@@ -55,6 +56,7 @@ impl Severity {
             Self::Low => Paint::yellow(message).bold().to_string(),
             Self::Info => Paint::cyan(message).bold().to_string(),
             Self::Gas => Paint::green(message).bold().to_string(),
+            Self::CodeSize => Paint::green(message).bold().to_string(),
         }
     }
 }
@@ -63,7 +65,7 @@ impl From<Severity> for Level {
     fn from(severity: Severity) -> Self {
         match severity {
             Severity::High | Severity::Med | Severity::Low => Self::Warning,
-            Severity::Info | Severity::Gas => Self::Note,
+            Severity::Info | Severity::Gas | Severity::CodeSize => Self::Note,
         }
     }
 }
@@ -76,6 +78,7 @@ impl fmt::Display for Severity {
             Self::Low => self.color("Low"),
             Self::Info => self.color("Info"),
             Self::Gas => self.color("Gas"),
+            Self::CodeSize => self.color("CodeSize"),
         };
         write!(f, "{colored}")
     }
@@ -102,8 +105,9 @@ impl FromStr for Severity {
             "low" => Ok(Self::Low),
             "info" => Ok(Self::Info),
             "gas" => Ok(Self::Gas),
+            "size" | "codesize" | "code-size" => Ok(Self::CodeSize),
             _ => Err(format!(
-                "unknown variant: found `{s}`, expected `one of `High`, `Med`, `Low`, `Info`, `Gas``"
+                "unknown variant: found `{s}`, expected `one of `High`, `Med`, `Low`, `Info`, `Gas`, CodeSize`"
             )),
         }
     }

crates/lint/src/sol/codesize/mod.rs

@@ -0,0 +1,6 @@
+use crate::sol::{EarlyLintPass, LateLintPass, SolLint};
+
+mod unwrapped_modifier_logic;
+use unwrapped_modifier_logic::UNWRAPPED_MODIFIER_LOGIC;
+
+register_lints!((UnwrappedModifierLogic, late, (UNWRAPPED_MODIFIER_LOGIC)));

crates/lint/src/sol/gas/unwrapped_modifier_logic.rs renamed to crates/lint/src/sol/codesize/unwrapped_modifier_logic.rs

@@ -3,10 +3,4 @@ use crate::sol::{EarlyLintPass, LateLintPass, SolLint};
 mod keccak;
 use keccak::ASM_KECCAK256;
 
-mod unwrapped_modifier_logic;
-use unwrapped_modifier_logic::UNWRAPPED_MODIFIER_LOGIC;
-
-register_lints!(
-    (AsmKeccak256, late, (ASM_KECCAK256)),
-    (UnwrappedModifierLogic, late, (UNWRAPPED_MODIFIER_LOGIC))
-);
+register_lints!((AsmKeccak256, late, (ASM_KECCAK256)),);

crates/lint/src/sol/gas/mod.rs

@@ -27,6 +27,7 @@ use thiserror::Error;
 #[macro_use]
 pub mod macros;
 
+pub mod codesize;
 pub mod gas;
 pub mod high;
 pub mod info;
@@ -38,6 +39,7 @@ static ALL_REGISTERED_LINTS: LazyLock<Vec<&'static str>> = LazyLock::new(|| {
     lints.extend_from_slice(med::REGISTERED_LINTS);
     lints.extend_from_slice(info::REGISTERED_LINTS);
     lints.extend_from_slice(gas::REGISTERED_LINTS);
+    lints.extend_from_slice(codesize::REGISTERED_LINTS);
     lints.into_iter().map(|lint| lint.id()).collect()
 });
 
@@ -109,9 +111,10 @@ impl SolidityLinter {
         passes_and_lints.extend(med::create_early_lint_passes());
         passes_and_lints.extend(info::create_early_lint_passes());
 
-        // Do not apply gas-severity rules on tests and scripts
+        // Do not apply 'gas' and 'codesize' severity rules on tests and scripts
         if !self.path_config.is_test_or_script(path) {
             passes_and_lints.extend(gas::create_early_lint_passes());
+            passes_and_lints.extend(codesize::create_early_lint_passes());
         }
 
         // Filter passes based on linter config
@@ -146,11 +149,12 @@ impl SolidityLinter {
         passes_and_lints.extend(med::create_late_lint_passes());
         passes_and_lints.extend(info::create_late_lint_passes());
 
-        // Do not apply gas-severity rules on tests and scripts
+        // Do not apply 'gas' and 'codesize' severity rules on tests and scripts
         if let FileName::Real(ref path) = file.name
             && !self.path_config.is_test_or_script(path)
         {
             passes_and_lints.extend(gas::create_late_lint_passes());
+            passes_and_lints.extend(codesize::create_late_lint_passes());
         }
 
         // Filter passes based on config