Merge pull request #2729 from dajiaohuang/fix/2728-scoped-external-search

Fix scoped external-search shortcuts

Author: simon04

assets/javascripts/views/search/search.js

@@ -141,7 +141,7 @@ app.views.Search = class Search extends app.View {
   }
 
   externalSearch(url) {
-    const value = this.value;
+    let value = this.value;
     if (value) {
       if (this.scope.name()) {
         value = `${this.scope.name()} ${value}`;

test/assets/search_hash_test.js

@@ -48,3 +48,19 @@ test("URL search hash preserves encoded literal plus signs in the query", () =>
 
   assert.equal(search.getHashValue(), "operator+");
 });
+
+test("scoped external search includes the documentation name", () => {
+  let popupUrl;
+  context.$.popup = (url) => {
+    popupUrl = url;
+  };
+
+  const search = Object.create(context.app.views.Search.prototype);
+  search.value = "status";
+  search.scope = { name: () => "Git" };
+  search.reset = () => {};
+
+  search.externalSearch("https://www.google.com/search?q=");
+
+  assert.equal(popupUrl, "https://www.google.com/search?q=Git%20status");
+});