rtld, libthr: Use nonstring attribute to silence compiler warning

With Clang 21 at least, we start to get warnings like:

```
rtld.c:333:58: error: initializer-string for character array is too long, array size is 4 but initializer has size 5 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
  333 |         static const char rtld_utrace_sig[RTLD_UTRACE_SIG_SZ] = RTLD_UTRACE_SIG;
      |                                                                 ^~~~~~~~~~~~~~~
./rtld_utrace.h:49:27: note: expanded from macro 'RTLD_UTRACE_SIG'
   49 | #define RTLD_UTRACE_SIG                 "RTLD"
      |
```

Looking up the `nonstring` attribute [1], it does seem to be the correct
thing --- indicating a char array which should not have a null
terminator byte --- to use in these two cases.

Note: I discovered this when fixing Nixpkgs's FreeBSD cross compilation
support. I understand that FreeBSD may not officially support this
version of Clang yet, and so the CPP that is needed is a bit annoying.
But it still hopefully will make things easier once it comes time to
bump the supported version of Clang to one with this attribute.

I am hoping thus that this patch is acceptable, as just early readiness
for when FreeBSD does upgrade to that version of Clang.

[1]: https://clang.llvm.org/docs/AttributeReference.html#nonstring

Signed-off-by: John Ericson <[email protected]>

Author: Ericson2314

lib/libthr/thread/thr_printf.c

@@ -58,10 +58,18 @@ _thread_printf(int fd, const char *fmt, ...)
 	va_end(ap);
 }
 
+/* GCC has had this for a long while now, but Clang only got it
+   recently. */
+#if __has_attribute(__nonstring__)
+# define	__nonstring __attribute__((__nonstring__))
+#else
+# define	__nonstring
+#endif
+
 void
 _thread_vprintf(int fd, const char *fmt, va_list ap)
 {
-	static const char digits[16] = "0123456789abcdef";
+	__nonstring static const char digits[16] = "0123456789abcdef";
 	char buf[20];
 	char *s;
 	unsigned long r, u;

libexec/rtld-elf/rtld.c

@@ -343,12 +343,20 @@ static void (*rtld_exit_ptr)(void);
 			ld_utrace_log(e, h, mb, ms, r, n); \
 	} while (0)
 
+/* GCC has had this for a long while now, but Clang only got it
+   recently. */
+#if __has_attribute(__nonstring__)
+# define	__nonstring __attribute__((__nonstring__))
+#else
+# define	__nonstring
+#endif
+
 static void
 ld_utrace_log(int event, void *handle, void *mapbase, size_t mapsize,
     int refcnt, const char *name)
 {
 	struct utrace_rtld ut;
-	static const char rtld_utrace_sig[RTLD_UTRACE_SIG_SZ] = RTLD_UTRACE_SIG;
+	__nonstring static const char rtld_utrace_sig[RTLD_UTRACE_SIG_SZ] = RTLD_UTRACE_SIG;
 
 	memset(&ut, 0, sizeof(ut));	/* clear holes */
 	memcpy(ut.sig, rtld_utrace_sig, sizeof(ut.sig));