Fix issue with recursive loop

Author: gawsoftpl

bin/start-e2e-test-server.sh

@@ -3,4 +3,4 @@
 npm run test:start-node-server &
 npm run test:start-node-server2 &
 ./tests/e2e/grpc-go-server-reflection/grpc-reflection-server &
-sleep 2
+sleep 4

src/GrpcReflection.ts

@@ -75,18 +75,16 @@ export class GrpcReflection {
      */
     getServiceMethods(descriptor: grpc.GrpcObject, service: string): Array<ListMethodsType>
     {
-        let anti_recusive = 0
+        let anti_recursive = 0
         let actualDescriptor : any = descriptor;
-        let found = false;
         const path = this.generateServicePath(service);
         do {
-            const service = path.pop();
-            if (service && service in actualDescriptor){
-                actualDescriptor = actualDescriptor[service];
-                found = true;
+            const serviceName = path.pop();
+            if (serviceName && serviceName in actualDescriptor){
+                actualDescriptor = actualDescriptor[serviceName];
             }
-            anti_recusive++;
-        }while(anti_recusive < 100 && !found);
+            anti_recursive++
+        } while (path.length > 0 && anti_recursive < 100);
         if ('service' in actualDescriptor) {
             return Object.entries(actualDescriptor.service)
                 .map(([methodName, methodDefinition]) => ({

tests/e2e/listMethods.test.ts

@@ -1,4 +1,4 @@
-import {GrpcReflection} from "../../src";
+import {GrpcReflection, ReflectionRequestException} from "../../src";
 import * as grpc from '@grpc/grpc-js';
 
 describe("Test list methods of helloworld.proto", () => {
@@ -22,4 +22,8 @@ describe("Test list methods of helloworld.proto", () => {
 
     });
 
+    it("Should thor exception on not found service", async() =>{
+        await expect(client.listMethods('not-found.Greeter')).rejects.toThrow(ReflectionRequestException);
+    });
+
 });