Skip to content

Commit ff01f0e

Browse files
Merge pull request #244 from getappbox/develop
Fix app is not installing due to invalid dropbox direct download URL
2 parents 629c8c4 + dad0cf5 commit ff01f0e

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

AppBox.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1222,7 +1222,7 @@
12221222
CODE_SIGN_ENTITLEMENTS = AppBox/AppBox.entitlements;
12231223
CODE_SIGN_IDENTITY = "Mac Developer";
12241224
COMBINE_HIDPI_IMAGES = YES;
1225-
CURRENT_PROJECT_VERSION = 5;
1225+
CURRENT_PROJECT_VERSION = 1;
12261226
DEVELOPMENT_TEAM = 3PQ7E4L589;
12271227
ENABLE_APP_SANDBOX = YES;
12281228
ENABLE_HARDENED_RUNTIME = YES;
@@ -1253,7 +1253,7 @@
12531253
LD_DYLIB_INSTALL_NAME = "";
12541254
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
12551255
MACOSX_DEPLOYMENT_TARGET = 10.11;
1256-
MARKETING_VERSION = 3.0.0;
1256+
MARKETING_VERSION = 3.0.1;
12571257
PRODUCT_BUNDLE_IDENTIFIER = com.developerinsider.AppBox;
12581258
PRODUCT_NAME = "$(TARGET_NAME)";
12591259
USER_HEADER_SEARCH_PATHS = "$(PROJECT_DIR)";
@@ -1268,7 +1268,7 @@
12681268
CODE_SIGN_ENTITLEMENTS = AppBox/AppBox.entitlements;
12691269
CODE_SIGN_IDENTITY = "Mac Developer";
12701270
COMBINE_HIDPI_IMAGES = YES;
1271-
CURRENT_PROJECT_VERSION = 5;
1271+
CURRENT_PROJECT_VERSION = 1;
12721272
DEVELOPMENT_TEAM = 3PQ7E4L589;
12731273
ENABLE_APP_SANDBOX = YES;
12741274
ENABLE_HARDENED_RUNTIME = YES;
@@ -1299,7 +1299,7 @@
12991299
LD_DYLIB_INSTALL_NAME = "";
13001300
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
13011301
MACOSX_DEPLOYMENT_TARGET = 10.11;
1302-
MARKETING_VERSION = 3.0.0;
1302+
MARKETING_VERSION = 3.0.1;
13031303
PRODUCT_BUNDLE_IDENTIFIER = com.developerinsider.AppBox;
13041304
PRODUCT_NAME = "$(TARGET_NAME)";
13051305
USER_HEADER_SEARCH_PATHS = "$(PROJECT_DIR)";

AppBox/Common/UploadManager/UploadManager.m

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,9 @@ -(void)handleSharedURLResult:(NSString *)url{
639639
//Create manifest file with share IPA url and upload manifest file
640640
if (self.dbFileType == DBFileTypeIPA) {
641641
NSString *shareableLink = url;
642+
shareableLink = [shareableLink stringByReplacingOccurrencesOfString:@"https://www.dropbox.com" withString:abDropBoxDirectDownload];
643+
shareableLink = [shareableLink stringByReplacingOccurrencesOfString:@"https://dropbox.com" withString:abDropBoxDirectDownload];
644+
shareableLink = [shareableLink substringToIndex:shareableLink.length-5];
642645
self.project.ipaFileDBShareableURL = [NSURL URLWithString:shareableLink];
643646
[self.project createManifestWithIPAURL:self.project.ipaFileDBShareableURL completion:^(NSURL *manifestURL) {
644647
strongify(self);
@@ -649,7 +652,7 @@ -(void)handleSharedURLResult:(NSString *)url{
649652
}
650653
[Common showAlertWithTitle:@"Error" andMessage:@"Unable to create manifest file!!"];
651654
self.errorBlock(nil, YES);
652-
}else{
655+
} else {
653656
//change file type and upload manifest
654657
self.dbFileType = DBFileTypeManifest;
655658
[self dbUploadFile:manifestURL.resourceSpecifier to:self.project.dbManifestFullPath.absoluteString mode:[[DBFILESWriteMode alloc] initWithOverwrite]];

AppBox/ViewController/HomeViewController/HomeViewController.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,10 @@ -(void)updateViewState{
317317
[textFieldEmail setEnabled:enable];
318318
[textFieldMessage setEnabled:enable];
319319

320+
//Reset text field content
321+
[textFieldEmail setStringValue: enable ? textFieldEmail.stringValue : abEmptyString];
322+
[textFieldMessage setStringValue: enable ? textFieldMessage.stringValue : abEmptyString];
323+
320324
//Just for confirm changes
321325
[self textFieldMailValueChanged:textFieldEmail];
322326
[self textFieldDevMessageValueChanged:textFieldMessage];

0 commit comments

Comments
 (0)