Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Commit f6ec18d

Browse files
committed
Stop type checking sample_rate in SentryHandler
1 parent 2fea4c8 commit f6ec18d

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

raven/handlers/logging.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,11 +175,6 @@ def _emit(self, record, **kwargs):
175175

176176
kwargs.update(handler_kwargs)
177177
sample_rate = extra.pop('sample_rate', None)
178-
try:
179-
if sample_rate is not None:
180-
sample_rate = float(sample_rate)
181-
except ValueError:
182-
sample_rate = None
183178

184179
return self.client.capture(
185180
event_type, stack=stack, data=data,

tests/handlers/logging/tests.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -273,12 +273,6 @@ def test_sample_rate(self):
273273

274274
self.assertEqual(len(self.client.events), 1)
275275

276-
def test_sample_rate_bad_values(self):
277-
record = self.make_record('Message', extra={'sample_rate': 'foo'})
278-
self.handler.emit(record)
279-
280-
self.assertEqual(len(self.client.events), 1)
281-
282276

283277
class LoggingHandlerTest(TestCase):
284278
def test_client_arg(self):

0 commit comments

Comments
 (0)