Skip to content

Commit 8d5bfcf

Browse files
committed
Third attempt at fixing Kotlin 2.2 compat
1 parent 6a8b15d commit 8d5bfcf

File tree

25 files changed

+92
-61
lines changed

25 files changed

+92
-61
lines changed

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ feign = "11.6"
1111
jacoco = "0.8.7"
1212
jackson = "2.18.3"
1313
jetbrainsCompose = "1.6.11"
14-
kotlin = "2.2.0"
14+
kotlin = "1.9.24"
1515
kotlinSpring7 = "2.2.0"
1616
kotlin-compatible-version = "1.9"
1717
ktorClient = "3.0.0"

sentry-android-integration-tests/sentry-uitest-android-critical/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import io.gitlab.arturbosch.detekt.Detekt
33
plugins {
44
id("com.android.application")
55
alias(libs.plugins.kotlin.android)
6-
alias(libs.plugins.kotlin.compose)
6+
// alias(libs.plugins.kotlin.compose)
77
}
88

99
android {

sentry-android-integration-tests/sentry-uitest-android/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import net.ltgt.gradle.errorprone.errorprone
44
plugins {
55
id("com.android.application")
66
alias(libs.plugins.kotlin.android)
7-
alias(libs.plugins.kotlin.compose)
7+
// alias(libs.plugins.kotlin.compose)
88
alias(libs.plugins.errorprone)
99
alias(libs.plugins.gradle.versions)
1010
alias(libs.plugins.detekt)

sentry-android-replay/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompilationTask
55
plugins {
66
id("com.android.library")
77
alias(libs.plugins.kotlin.android)
8-
alias(libs.plugins.kotlin.compose)
8+
// alias(libs.plugins.kotlin.compose)
99
jacoco
1010
alias(libs.plugins.jacoco.android)
1111
alias(libs.plugins.gradle.versions)

sentry-compose/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ kotlin {
1919

2020
androidTarget {
2121
publishLibraryVariants("release")
22-
compilerOptions { jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.fromTarget("1.8")) }
22+
compilations.all { kotlinOptions.jvmTarget = JavaVersion.VERSION_1_8.toString() }
2323
}
2424
jvm("desktop") {
25-
compilerOptions { jvmTarget.set(org.jetbrains.kotlin.gradle.dsl.JvmTarget.fromTarget("1.8")) }
25+
compilations.all { kotlinOptions.jvmTarget = JavaVersion.VERSION_1_8.toString() }
2626
}
2727

2828
sourceSets.all {

sentry-samples/sentry-samples-android/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import org.gradle.internal.extensions.stdlib.capitalized
66
plugins {
77
id("com.android.application")
88
alias(libs.plugins.kotlin.android)
9-
alias(libs.plugins.kotlin.compose)
9+
// alias(libs.plugins.kotlin.compose)
1010
}
1111

1212
android {

sentry-samples/sentry-samples-spring-7/build.gradle.kts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,12 @@ tasks.withType<Test>().configureEach { useJUnitPlatform() }
4646

4747
tasks.withType<KotlinCompile>().configureEach {
4848
kotlin {
49-
compilerOptions.freeCompilerArgs = listOf("-Xjsr305=strict")
49+
explicitApi()
50+
// skip metadata version check, as Spring 7 / Spring Boot 4 is
51+
// compiled against a newer version of Kotlin
52+
compilerOptions.freeCompilerArgs = listOf("-Xjsr305=strict", "-Xskip-metadata-version-check")
5053
compilerOptions.jvmTarget = org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_17
54+
compilerOptions.languageVersion = org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_1_9
55+
compilerOptions.apiVersion = org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_1_9
5156
}
5257
}

sentry-samples/sentry-samples-spring-7/src/main/java/io/sentry/samples/spring/jakarta/SecurityConfiguration.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ public class SecurityConfiguration {
2020
@SuppressWarnings({"lgtm[java/spring-disabled-csrf-protection]", "removal"})
2121
@Bean
2222
public SecurityFilterChain filterChain(final @NotNull HttpSecurity http) throws Exception {
23-
http.csrf().disable().authorizeHttpRequests().anyRequest().authenticated().and().httpBasic();
24-
25-
return http.build();
23+
return http.csrf((csrf) -> csrf.disable())
24+
.authorizeHttpRequests((r) -> r.anyRequest().authenticated())
25+
.httpBasic((h) -> {})
26+
.build();
2627
}
2728

2829
@Bean

sentry-samples/sentry-samples-spring-boot-4-opentelemetry-noagent/build.gradle.kts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,14 @@ configure<JavaPluginExtension> {
2424
}
2525

2626
tasks.withType<KotlinCompile>().configureEach {
27-
compilerOptions.jvmTarget = org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_17
2827
kotlin {
29-
compilerOptions.freeCompilerArgs = listOf("-Xjsr305=strict")
28+
explicitApi()
29+
// skip metadata version check, as Spring 7 / Spring Boot 4 is
30+
// compiled against a newer version of Kotlin
31+
compilerOptions.freeCompilerArgs = listOf("-Xjsr305=strict", "-Xskip-metadata-version-check")
3032
compilerOptions.jvmTarget = org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_17
33+
compilerOptions.languageVersion = org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_1_9
34+
compilerOptions.apiVersion = org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_1_9
3135
}
3236
}
3337

@@ -42,6 +46,7 @@ dependencies {
4246
implementation(libs.springboot4.starter.web)
4347
implementation(libs.springboot4.starter.webflux)
4448
implementation(libs.springboot4.starter.websocket)
49+
implementation(libs.springboot4.starter.restclient)
4550
implementation(Config.Libs.aspectj)
4651
implementation(Config.Libs.kotlinReflect)
4752
implementation(kotlin(Config.kotlinStdLib, KotlinCompilerVersion.VERSION))

sentry-samples/sentry-samples-spring-boot-4-opentelemetry-noagent/src/main/java/io/sentry/samples/spring/boot/jakarta/SecurityConfiguration.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,10 @@ public class SecurityConfiguration {
1818
@SuppressWarnings({"lgtm[java/spring-disabled-csrf-protection]", "removal"})
1919
@Bean
2020
public SecurityFilterChain filterChain(final @NotNull HttpSecurity http) throws Exception {
21-
http.csrf().disable().authorizeHttpRequests().anyRequest().authenticated().and().httpBasic();
22-
23-
return http.build();
21+
return http.csrf((csrf) -> csrf.disable())
22+
.authorizeHttpRequests((r) -> r.anyRequest().authenticated())
23+
.httpBasic((h) -> {})
24+
.build();
2425
}
2526

2627
@Bean

0 commit comments

Comments
 (0)