Skip to content

Commit a023305

Browse files
committed
feat: Include exception type in igoreErrors test
1 parent adb4501 commit a023305

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/raven.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,14 +1418,15 @@ Raven.prototype = {
14181418
},
14191419

14201420
_processException: function(type, message, fileurl, lineno, frames, options) {
1421-
var stacktrace;
1421+
var testString = (type || '') + ': ' + (message || '');
1422+
14221423
if (
14231424
!!this._globalOptions.ignoreErrors.test &&
1424-
this._globalOptions.ignoreErrors.test(message)
1425+
this._globalOptions.ignoreErrors.test(testString)
14251426
)
14261427
return;
14271428

1428-
message += '';
1429+
var stacktrace;
14291430

14301431
if (frames && frames.length) {
14311432
fileurl = frames[0].filename || fileurl;

test/raven.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,11 +478,13 @@ describe('globals', function() {
478478
it('should respect `ignoreErrors`', function() {
479479
this.sinon.stub(Raven, '_send');
480480

481-
Raven._globalOptions.ignoreErrors = joinRegExp(['e1', 'e2']);
481+
Raven._globalOptions.ignoreErrors = joinRegExp(['e1', 'e2', 'CustomError']);
482482
Raven._processException('Error', 'e1', 'http://example.com', []);
483483
assert.isFalse(Raven._send.called);
484484
Raven._processException('Error', 'e2', 'http://example.com', []);
485485
assert.isFalse(Raven._send.called);
486+
Raven._processException('CustomError', 'e3', 'http://example.com', []);
487+
assert.isFalse(Raven._send.called);
486488
Raven._processException('Error', 'error', 'http://example.com', []);
487489
assert.isTrue(Raven._send.calledOnce);
488490
});

0 commit comments

Comments
 (0)