Skip to content

Commit 0f7937b

Browse files
committed
ref(worker): Move worker flush_async from Worker ABC
Move the flush_async down to the concrete subclass to not break existing testing. This makes sense, as this will only really be needed by the async worker anyway and therefore is not shared logic. GH-4578
1 parent 8960e6f commit 0f7937b

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

sentry_sdk/worker.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,6 @@ def flush(
4545
"""
4646
return None
4747

48-
async def flush_async(
49-
self, timeout: float, callback: Optional[Callable[[int, float], None]] = None
50-
) -> None:
51-
"""
52-
Flush the worker.
53-
54-
This method can be awaited until the worker has flushed all events or the specified timeout is reached.
55-
Default implementation is a no-op, since this method may only be relevant to some workers.
56-
Subclasses should override this method if necessary.
57-
"""
58-
return None
59-
6048
@abstractmethod
6149
def full(self) -> bool:
6250
pass

0 commit comments

Comments
 (0)